Merge pull request #23 from raviprajapat/master

Validation fix when file extension in uppercase
vugar005 · Feb 5, 2020 · 6cbf07c · 6cbf07c
2 parents d48290a + acfddb2
commit 6cbf07c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/projects/file-picker/src/lib/file-picker.component.ts b/projects/file-picker/src/lib/file-picker.component.ts
@@ -294,7 +294,7 @@ export class FilePickerComponent implements OnInit, OnDestroy {
   isValidExtension(file: File, fileName: string): boolean {
     if (!this.fileExtensions) {return true; }
     const extension = fileName.split('.').pop();
-    if (this.fileExtensions && (!this.fileExtensions.includes(extension))) {
+    if (this.fileExtensions && (!this.fileExtensions.toLowerCase().includes(extension.toLowerCase()))) {
       this.validationError.next({file: file, error: FileValidationTypes.extensions});
       return false;
     }

diff --git a/projects/file-picker/src/lib/file-picker.spec.ts b/projects/file-picker/src/lib/file-picker.spec.ts
@@ -139,6 +139,15 @@ describe('FilePickerComponent', () => {
   expect(res).toBe(false);
   expect(component.validationError.next).toHaveBeenCalledWith({file: file, error: FileValidationTypes.extensions});
 
+});
+it('should isValidMaxExtension work if file extension in uppercase', () => {
+  component.fileExtensions = 'png';
+  spyOn(component.validationError, 'next');
+  const file = createMockFile('demo2.PNG', 'image/png');
+  const res =  component.isValidExtension(file, file.name);
+  expect(res).toBe(true);
+  expect(component.validationError.next).not.toHaveBeenCalled();
+
 });
  it('should isValidMaxFileCount work', () => {
   component.fileMaxCount = 1;