Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Commit

Permalink
Merge branch 'develop'
Browse files Browse the repository at this point in the history
  • Loading branch information
Agata Firlejczyk committed Oct 23, 2019
2 parents c819c83 + 28c96ab commit 282b2fb
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
### Fixes
- Fix Notice: Undefined index: value in ConfigurableData.php on line 254 ([#139](https://github.com/DivanteLtd/magento2-vsbridge-indexer/issues/139))
- Switch indices when all types will be reindex ([#138](https://github.com/DivanteLtd/magento2-vsbridge-indexer/pull/138))
- Change method name `AbstractEavAttributes:canReindex:canReindex` to 'cantReindexAttribute'
- Change method name `AbstractEavAttributes:canReindex` to '`AbstractEavAttributes:canIndexAttribute`

## [1.5.0]

### Changed/Improved
- Change method `AbstractEavAttributes:canReindex:canReindex` to public ([#136](https://github.com/DivanteLtd/magento2-vsbridge-indexer/pull/136))
- Change method `AbstractEavAttributes:canReindex` to public ([#136](https://github.com/DivanteLtd/magento2-vsbridge-indexer/pull/136))

### Added
- Add support for aliases ([#3](https://github.com/DivanteLtd/magento2-vsbridge-indexer/issues/3)).
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Sign up for a demo at https://vuestorefront.io/ (Vue Storefront integrated with

## Overview

### Version 1.5.1 - support for aliases.
### Version 1.5.0/1.5.1 - support for aliases.
Command ` php bin/magento vsbridge:reindex` will reindex all data to new index.
It will create new index and update aliases at the end.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public function loadAttributesData($storeId, array $entityIds, array $requiredAt
$selects = [];

foreach ($this->attributesById as $attributeId => $attribute) {
if ($this->canReindexAttribute($attribute, $requiredAttributes)) {
if ($this->canIndexAttribute($attribute, $requiredAttributes)) {
$tableAttributes[$attribute->getBackendTable()][] = $attributeId;

if (!isset($attributeTypes[$attribute->getBackendTable()])) {
Expand Down Expand Up @@ -121,7 +121,7 @@ public function loadAttributesData($storeId, array $entityIds, array $requiredAt
* @return bool
* @throws \Exception
*/
public function canReindexAttribute(\Magento\Eav\Model\Entity\Attribute $attribute, array $allowedAttributes = null)
public function canIndexAttribute(\Magento\Eav\Model\Entity\Attribute $attribute, array $allowedAttributes = null)
{
if ($attribute->isStatic()) {
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ public function loadAttributesData($storeId, array $entityIds, array $requiredAt
*
* @return bool
*/
public function canReindexAttribute(\Magento\Eav\Model\Entity\Attribute $attribute, array $allowedAttributes = null);
public function canIndexAttribute(\Magento\Eav\Model\Entity\Attribute $attribute, array $allowedAttributes = null);
}

0 comments on commit 282b2fb

Please sign in to comment.