Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-shiki): add built-in twoslash support #348

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Mister-Hope
Copy link
Member

No description provided.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for vuepress-ecosystem ready!

Name Link
🔨 Latest commit bb50152
🔍 Latest deploy log https://app.netlify.com/sites/vuepress-ecosystem/deploys/6793b03ce6a3a50008c2312f
😎 Deploy Preview https://deploy-preview-348--vuepress-ecosystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for vuepress-ecosystem ready!

Name Link
🔨 Latest commit 5e6f8a2
🔍 Latest deploy log https://app.netlify.com/sites/vuepress-ecosystem/deploys/6793b045fc18450008a4bf6f
😎 Deploy Preview https://deploy-preview-348--vuepress-ecosystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mister-Hope
Copy link
Member Author

@pengzhanbo It seems that you already implement a good approach in your theme, please consider migrating the feature upstream.

@coveralls
Copy link

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 12952490540

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 7 (42.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 59.612%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-shiki/src/node/transformers/getTransformers.ts 3 7 42.86%
Totals Coverage Status
Change from base Build 12952482974: -0.07%
Covered Lines: 1349
Relevant Lines: 2046

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants