Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): inconsistent behaviour on nested transition groups #8803

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

daniser
Copy link

@daniser daniser commented Jul 18, 2023

fixes #1531
close #5385

@skirtles-code
Copy link
Contributor

For anyone trying to review this, here's the original reproduction, converted to a Playground:

Here's the same example but running on this PR:

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to merge in main, to resolve the conflicts and get the latest ESLint rules?

packages/runtime-dom/src/components/TransitionGroup.ts Outdated Show resolved Hide resolved
@daniser
Copy link
Author

daniser commented Jun 24, 2024

@skirtles-code Done!

Copy link

github-actions bot commented Aug 20, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+146 B) 38 kB (+45 B) 34.2 kB (+17 B)
vue.global.prod.js 159 kB (+146 B) 57.9 kB (+38 B) 51.5 kB (+22 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 21 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

@edison1105
Copy link
Member

/ecosystem-ci run

Copy link

pkg-pr-new bot commented Aug 20, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@8803

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@8803

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@8803

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@8803

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@8803

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@8803

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@8803

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@8803

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@8803

vue

pnpm add https://pkg.pr.new/vue@8803

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@8803

commit: 29a1647

@vue-bot
Copy link
Contributor

vue-bot commented Aug 20, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added 🐞 bug Something isn't working scope: transition ready for review This PR requires more reviews labels Aug 20, 2024
@daniser
Copy link
Author

daniser commented Sep 13, 2024

Any estimate on when it'll be merged? It's been over a year.

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Nov 4, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue failure failure
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member

/ecosystem-ci run vite-plugin-vue

@vue-bot
Copy link
Contributor

vue-bot commented Nov 4, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
vite-plugin-vue success failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ready for review This PR requires more reviews scope: transition
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Unnecessary move animation in nested <transition-group> inconsistent behaviour on nested transition groups
4 participants