Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support v-model for <details> and <dialog> #8048

Open
wants to merge 3 commits into
base: minor
Choose a base branch
from
Open

feat: support v-model for <details> and <dialog> #8048

wants to merge 3 commits into from
+205 −3

Conversation

antfu
Copy link
Member

@antfu antfu commented Apr 8, 2023 •
edited
Loading

This was referenced Apr 8, 2023
Open
Open
@antfu antfu requested a review from yyx990803 April 8, 2023 13:20
@yyx990803
Copy link
Member

Looks like this is lacking runtime behavior tests in https://github.com/vuejs/core/blob/main/packages/runtime-dom/__tests__/directives/vModel.spec.ts

@antfu
Copy link
Member Author

antfu commented Apr 10, 2023

Test added, resolveDynamicModel updated.

@antfu antfu mentioned this pull request Apr 13, 2023
Closed
4 tasks
@antfu antfu added the ready to merge The PR is ready to be merged. label Jun 7, 2023
@sxzz sxzz force-pushed the feat/v-model-details-dialog branch from 3e2efe0 to eb5ca19 Compare August 21, 2023 08:13
@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.2 kB (+433 B) 32.7 kB (+97 B) 29.5 kB (+90 B)
vue.global.prod.js 132 kB (+568 B) 49.4 kB (+125 B) 44.3 kB (+35 B)

Usages

Name Size Gzip Brotli
createApp 47.7 kB 18.9 kB 17.2 kB
createSSRApp 50.5 kB 19.9 kB 18.2 kB
defineCustomElement 50.1 kB 19.6 kB 17.9 kB
overall 61.1 kB 23.7 kB 21.6 kB

@sxzz sxzz changed the base branch from main to 3.4 September 2, 2023 07:40
@sxzz sxzz mentioned this pull request Sep 5, 2023
Closed
@sxzz sxzz changed the base branch from 3.4 to minor September 21, 2023 11:49
@sxzz sxzz force-pushed the minor branch 2 times, most recently from dc30885 to be91d43 Compare September 22, 2023 08:11
@sxzz sxzz force-pushed the minor branch 4 times, most recently from 5d93a55 to 06ad749 Compare October 20, 2023 09:35
@amir20
Copy link

amir20 commented Dec 15, 2023

Hello! I didn't see this particular feature mentioned in 3.4 release candidate. Is this still planned? Thanks.

@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 deleted the feat/v-model-details-dialog branch October 21, 2024 07:36
@edison1105 edison1105 restored the feat/v-model-details-dialog branch October 21, 2024 08:25
@edison1105 edison1105 reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 left review comments

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged. scope: compiler scope: v-model version: minor
Projects
Issue / PR Management
Status: Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antfu @yyx990803 @amir20 @sxzz @edison1105