Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): handle initial selected state for select with v-model + v-for option #12399

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

edison1105
Copy link
Member

close #12395

Copy link

github-actions bot commented Nov 15, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.9 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB 57.8 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.1 kB 18.3 kB 16.8 kB
createApp 55.1 kB 21.3 kB 19.5 kB
createSSRApp 59.2 kB 23 kB 21 kB
defineCustomElement 60 kB 22.9 kB 20.8 kB
overall 69 kB 26.4 kB 24.1 kB

Copy link

pkg-pr-new bot commented Nov 15, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12399

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12399

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12399

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12399

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12399

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12399

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12399

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12399

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12399

vue

pnpm add https://pkg.pr.new/vue@12399

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12399

commit: ea204aa

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Nov 15, 2024
@yyx990803 yyx990803 merged commit 4f8d807 into main Nov 15, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/12395 branch November 15, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select v-model does not set 'selected' attribute on option with v-for directive using SSR
2 participants