-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: remove CMD line and docker-compose file is added #128
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really should be PR'ed against the develop
branch. I can port back to develop
branch if you don't want to open a new PR.
command: | ||
- --db-path=/home/monero-lws/.bitmonero/light_wallet_server | ||
- --daemon=tcp://monero:1882 | ||
- --sub=tcp://monero:18084 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--sub
and --zmq-pub
need to be on different ports. --zmq-pub
needs to match the zmq-pub port of monerod
and --sub
can be any available port.
- --daemon=tcp://monero:1882 | ||
- --sub=tcp://monero:18084 | ||
- --zmq-pub=tcp://monero:18084 | ||
- --log-level=4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default log-level should be 0, as 4 spams lots of data to disk.
- --log-level=4 | ||
- --webhook-ssl-verification=none | ||
- --disable-admin-auth | ||
- --admin-rest-server=http://0.0.0.0:8443/admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default should be https
or port 8080
. I would advocate for https
, but transient certificates are a kludge.
- --webhook-ssl-verification=none | ||
- --disable-admin-auth | ||
- --admin-rest-server=http://0.0.0.0:8443/admin | ||
- --rest-server=http://0.0.0.0:8443/basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
Improved Containerization with Docker Compose
Summary
This pull request updates the containerization approach for the repository by changing the Dockerfile and adding a docker-compose.yml file. This change aims to improve build times and provide greater flexibility when adjusting command-line arguments, enhancing the development workflow.
Changes Made
1. Dockerfile Update:
2. Introduction of Docker Compose:
Benefits
Please review the changes and let me know if any further adjustments are needed. Thank you for considering this improvement to the project's containerization process.