Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds hitRate to DiskCache #528

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds hitRate to DiskCache #528

wants to merge 2 commits into from

Conversation

danzanzini
Copy link

What is the purpose of this pull request?

This PR adds the hitRate metric to the DiskCache implementation.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

filipewl
filipewl approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipewl filipewl filipewl approved these changes

@Jeymisson Jeymisson Awaiting requested review from Jeymisson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danzanzini @filipewl