fix: Fuzzy usage when handling IS API requests #2565
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
hellofanny
commented
Nov 14, 2024
Comment on lines
+56
to
+61
| const hasFuzzy = findFacetValue(selectedFacets, 'fuzzy') | ||
|
|
||
| if(!hasFuzzy) { | ||
| return <EmptySearch /> | ||
| } | ||
|
|
There was a problem hiding this comment.
The only change that differ from #2204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR aims to correct fuzzy and operator usage when handling Intelligent Search API requests.
Previously, we specified a default value for fuzzy
fuzzy=auto. But we shouldn’t include it on the first request to Search. According to the IS team, the correct behavior should let the search engine decide the best parameters for the search.Re-applies changes made from #2204 without adding the blink effect added previously.
How it works?
How to test it?
Starters Deploy Preview
References