Allow different images per specification #2245
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
gvc
requested review from
hellofanny and
renatamottam
and removed request for
a team
There was a problem hiding this comment.
I don't know if there is any problem using this approach, but I've tried and it's working as expected. Well done guila 🚀
Curiosity: I noticed that testing in the starter, there was a strange behaviour happening, the labels were changing places, but now it's not. Did you do anything specific related to fix it? 🤔
change.size.labels.mov
|
I noticed that as well, Fanny, but I didn't do anything to change it in this PR. This might be related to the actual data in the account, but it wouldn't explain why it's working on my test PR. |
What's the purpose of this pull request?
The goal of this PR is to allow merchants to pick different SKU selector images for different SKU specifications. The current solution only allows one image to be picked for all Specifications. So a product with more than one Specification would look like this:
If this PR gets merged, given the two Specifications (Material and Size) and properly labeled images (
skuvariationmaterialandskuvariationsize) merchants can pick different images for each variation, the end result being:The name of the label and the fact that it has to be allinasingleword is a limitation of how the Catalog image uploader handles non-alphanumeric characters.
How to test it?
Go to the starter deploy preview and look for Awesome Chair. You should see different images for each SKU Selector. If you go to the production starter you will see the same image on both SKU Selectors.
References
I had to figure out a lot of things to create this new product (Awesome Chair) and this doc is what made everything click regarding SKUs and Specifications, you should check it out :)