Config settings for sockets permissions and some minor fixes. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some minor fixes to rmilter.init
| @@ -25,8 +23,7 @@ DESC="Rmilter Mail Filter Daemon" | |||
| PIDFILE="/var/run/$NAME.pid" | |||
| PNAME="rmilter" | |||
| USER="rmilter" | |||
| SOCKET=/var/lib/rmilter/rmilter.sock | |||
|
|
|||
| SOCKET=/var/spool/postfix/rmilter/rmilter.sock | |||
There was a problem hiding this comment.
This is a wrong path actually. The problem is that rmilter is not intended to run with Postfix MTA only, therefore it should create socket into some other path. The proper solution is to read from /etc/defaults/rmilter the name of the socket and use it in the init script.
There was a problem hiding this comment.
Possible to override any variable, because bellow occured that line:
test -f /etc/default/rmilter && . /etc/default/rmilter
…hat option sends signal HUP to rmilter. Permissions for temporary files changing moved to other place - where is temporary file created.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day!
I added settings file_mode for clamav unix domain socket and settings bind_socket_mode for rmilter itself unix domain socket. I fixed parsing of numbers to autodetect octal, hexadecimail and decimal numbers. And i fixed rmilter.init file to use SOCK settings and remove code duplication.
Fixes was tested with Postfix.