Skip to content

Commit

Permalink
Recognize MSVS 12 tools version for external projects too
Browse files Browse the repository at this point in the history
According to https://msdn.microsoft.com/en-us/library/bb383796.aspx, this is
the native value used by MSVS 2013, but we didn't recognize it before,
presumably because we only tested with the external projects originally
created in a previous MSVS version and updated to VS 2013 later.

Do recognize 12, in addition to 4 (MSVS 2010 and 2012) and 14 (MSVS 2015) too
now.
  • Loading branch information
vadz committed Apr 3, 2016
1 parent e9ce178 commit 149f36b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/bkl/plugins/external.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ def version(self):
v = self.xml.get("ToolsVersion")
if v == "14.0":
return 14
elif v == "12.0":
return 12
elif v != "4.0":
raise Error("unrecognized version of Visual Studio project %s: ToolsVersion=\"%s\"" %(
self.projectfile, v))
Expand Down

0 comments on commit 149f36b

Please sign in to comment.