Add Keycloak provisioning #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
force-pushed
the
add/keycloak_bootstrap
branch
2 times, most recently
from
4669e00 to
c527b2d
Compare
megian
reviewed
Jan 25, 2024
Kidswiss
force-pushed
the
add/keycloak_bootstrap
branch
from
47f9cac to
42217dd
Compare
megian
reviewed
Jan 25, 2024
megian
reviewed
Jan 25, 2024
megian
requested changes
Jan 25, 2024
With this commit it's now possible to provision a fairly default Keycloak instance backed by our PostgreSQL implementation.
Kidswiss
force-pushed
the
add/keycloak_bootstrap
branch
from
e1ef271 to
17ea5cf
Compare
Kidswiss
force-pushed
the
add/keycloak_bootstrap
branch
from
17ea5cf to
418fde9
Compare
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
wejdross
approved these changes
Jan 31, 2024
Comment on lines
+94
to
+99
| # curl ${STACKGRES_CRD_URL}/SGPoolingConfig.yaml?inline=false -o apis/stackgres/v1/sgpoolconfigs_crd.yaml | ||
| # yq -i e apis/stackgres/v1/sgpoolconfigs.yaml --expression ".components.schemas.SGPoolingConfigSpec=load(\"apis/stackgres/v1/sgpoolconfigs_crd.yaml\").spec.versions[0].schema.openAPIV3Schema.properties.spec" | ||
| # yq -i e apis/stackgres/v1/sgpoolconfigs.yaml --expression ".components.schemas.SGPoolingConfigStatus=load(\"apis/stackgres/v1/sgpoolconfigs_crd.yaml\").spec.versions[0].schema.openAPIV3Schema.properties.status" | ||
| # go run github.com/deepmap/oapi-codegen/cmd/oapi-codegen --package=v1 -generate=types -o apis/stackgres/v1/sgpoolconfigs.gen.go apis/stackgres/v1/sgpoolconfigs.yaml | ||
| # perl -i -0pe 's/\*struct\s\{\n\s\sAdditionalProperties\smap\[string\]string\s`json:"-"`\n\s}/map\[string\]string/gms' apis/stackgres/v1/sgpoolconfigs.gen.go | ||
|
|
There was a problem hiding this comment.
is it still necessary? or just left for future us?
There was a problem hiding this comment.
For future us. It probably makes sense if I add a comment though.
tl;dr: the generator for the pool configs doesn't work very well, as it relies on map[string]string which the go tooling can't handle. I guess it works with java though. So I had to replace parts of the generated code.
apis/stackgres/v1/sgpoolconfigs.go
Outdated
Comment on lines
14
to
18
| // Spec defines the desired state of a VSHNPostgreSQL. | ||
| Spec SGPoolingConfigSpec `json:"spec"` | ||
|
|
||
| // Status reflects the observed state of a VSHNPostgreSQL. | ||
| Status SGPoolingConfigStatus `json:"status,omitempty"` |
There was a problem hiding this comment.
looks like copy-paste issue in comments
There was a problem hiding this comment.
Good catch, I'll change the postgresql references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this commit it's now possible to provision a fairly default Keycloak instance backed by our PostgreSQL implementation.
There are currently no TLS configurations for Keycloak itself or its ingress. Also it currently only provisions in dev mode which has some things disabled like strict hostname checking and tls.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog