Fix leaked backups #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All backups in the cluster are being leaked due to APPCAT-563
wejdross
approved these changes
Oct 30, 2023
Kidswiss
approved these changes
Oct 30, 2023
bastjan
reviewed
Oct 30, 2023
| @@ -24,5 +24,16 @@ func (c *concreteRedisProvider) ListVSHNRedis(ctx context.Context, namespace str | |||
| return nil, err | |||
| } | |||
|
|
|||
| cleanedList := make([]vshnv1.VSHNRedis, 0) | |||
| for _, p := range instances.Items { | |||
There was a problem hiding this comment.
Shouldn't this be symetric to the ListXVSHNPostgreSQL() function? Nothing in the method name or docs indicates that this list is filtered by a random field. I would have put it here naively:
Also it is never regression tested.
There was a problem hiding this comment.
VSHN Redis is helm based and we use the claim and not the XRD.
Regarding regression test, I will check what I can do there. I update the unit tests which covers the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All backups in the cluster are being leaked due to APPCAT-563. Here we make sure to filter out all Custom Resources that do not have an InstanceNamespace. Having an empty InstanceNamespace will leak all backups later on in the business logic.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog