Bump ci vulkan sdk #1306
Merged
Bump ci vulkan sdk #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously-used version is no longer available so CI fails for committers who don't already have it cached in their fork. We can't bump the version more than this as the archive formats were switched and humbletim/install-vulkan-sdk can't handle that yet.
The latest release can't handle newer MacOS builds.
|
I have merged this PR as a branch and will see what happens with the automated build: https://github.com/vsg-dev/VulkanSceneGraph/tree/AnyOldName3-bump-ci-vulkan-sdk |
|
@AnyOldName3 automated build has run cleanly, is there any more testing we need to do before I merged with VSG master? |
|
It's not exactly more testing, as it's already happened, but here's a CI run on my fork from the gamma correctness branch which failed due to not having these commits https://github.com/AnyOldName3/VulkanSceneGraph/actions/runs/11332586516/job/31515009697 and one from this branch that now works https://github.com/AnyOldName3/VulkanSceneGraph/actions/runs/11350773480/job/31569912536 |
|
So go ahead and merge with VSG master? |
|
Yeah, I think it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI for forks by:
install-vulkan-sdkthat can handle slightly newer Vulkan SDK packages.It doesn't switch to the latest release as no version of
install-vulkan-sdkcan deal with it yet.