cppcheck fixes

vsg-dev · Oct 16, 2024 · c7c632d · c7c632d
1 parent d1c6f19
commit c7c632d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/cmake/cppcheck-suppression-list.txt b/cmake/cppcheck-suppression-list.txt
@@ -225,6 +225,11 @@ constParameterReference:*/src/vsg/app/RecordAndSubmitTask.cpp
 
 // suppress inappropriate warning
 constVariableReference:*/src/vsg/app/RecordTraversal.cpp
+constVariableReference:*/src/vsg/utils/ShaderSet.cpp
 
 // suppress inappropriate warning
 constVariablePointer:*/src/vsg/app/SecondaryCommandGraph.cpp
+
+// suppress inappropriate warning
+passedByValue:*/src/vsg/vk/Device.cpp
+passedByValue:*/src/vsg/vk/Instance.cpp
diff --git a/src/vsg/text/StandardLayout.cpp b/src/vsg/text/StandardLayout.cpp
@@ -288,23 +288,23 @@ void StandardLayout::layout(const Data* text, const Font& font, TextQuads& quads
         void apply(const ubyteArray& text) override
         {
             reserve(text.size());
-            for (auto& c : text)
+            for (const auto& c : text)
             {
                 character(c);
             }
         }
         void apply(const ushortArray& text) override
         {
             reserve(text.size());
-            for (auto& c : text)
+            for (const auto& c : text)
             {
                 character(c);
             }
         }
         void apply(const uintArray& text) override
         {
             reserve(text.size());
-            for (auto& c : text)
+            for (const auto& c : text)
             {
                 character(c);
             }

diff --git a/src/vsg/vk/Device.cpp b/src/vsg/vk/Device.cpp
@@ -76,7 +76,7 @@ Device::Device(PhysicalDevice* physicalDevice, const QueueSettings& queueSetting
 
         // check to see if the queueFamilyIndex has already been referenced or is unique
         bool unique = true;
-        for (auto& existingInfo : queueCreateInfos)
+        for (const auto& existingInfo : queueCreateInfos)
         {
             if (existingInfo.queueFamilyIndex == static_cast<uint32_t>(queueSetting.queueFamilyIndex)) unique = false;
         }