Linux: zhold znode when handing out link to VFS

Other linux fs implementations seem to hold a reference to some buffer which seems to cause the inode to stay in place in tight memory conditions. Replicate such behavior. Signed-off-by: Pavel Snajdr <[email protected]>
vpsfreecz · Oct 30, 2024 · 57568af · 57568af
1 parent 35b1a81
commit 57568af
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/module/os/linux/zfs/zpl_inode.c b/module/os/linux/zfs/zpl_inode.c
@@ -694,10 +694,19 @@ zpl_symlink(struct inode *dir, struct dentry *dentry, const char *name)
 	return (error);
 }
 
+struct zpl_link_info {
+	znode_t *zp;
+	char *name;
+};
+
 static void
 zpl_put_link(void *ptr)
 {
-	kmem_free(ptr, MAXPATHLEN);
+	struct zpl_link_info *zpl_li = ptr;
+
+	zrele(zpl_li->zp);
+	kmem_free(zpl_li->name, MAXPATHLEN);
+	kmem_free(zpl_li, sizeof (struct zpl_link_info));
 }
 
 static int
@@ -734,7 +743,8 @@ static const char *
 zpl_get_link(struct dentry *dentry, struct inode *inode,
     struct delayed_call *done)
 {
-	char *link = NULL;
+	char *link;
+	struct zpl_link_info *zpl_li;
 	int error;
 
 	if (!dentry)
@@ -744,7 +754,11 @@ zpl_get_link(struct dentry *dentry, struct inode *inode,
 	if (error)
 		return (ERR_PTR(error));
 
-	set_delayed_call(done, zpl_put_link, link);
+	zpl_li = kmem_zalloc(sizeof (struct zpl_link_info), KM_SLEEP);
+	zpl_li->zp = ITOZ(inode);
+	zhold(zpl_li->zp);
+	zpl_li->name = link;
+	set_delayed_call(done, zpl_put_link, zpl_li);
 
 	return (link);
 }