Fix and improve monthly sync information #405
Merged
+93
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time Zones are a PITA, the meeting incidently happen at 15:30 UTC at the moment, but it is in reality scheduled at 16:30 CET (UTC+1) during the winter and 16:30 CEST (UTC+2) when daylight sayving take place during the summer. Fix the indication so that it matches reality. Because converting from one time-zone to an other is something nobody like to do, add some JavaScript code to do it for us and display when the next monthly sync will take place. For this we rely on moment.js to do the math (as everybody knows, JS sucks and it lacks some time-zone functions) and format the time of the event conveniently for the user in their time zone (with formatting such as "Tomorrow at 5:30 AM" when the date is near). Last, but not least, provide a .ics file with the same information one more time so that people can easily choose what they prefer. Compared to the event in the Puppetlabs calendar, this one supposely has the correct time-zone and should avoid the mess that happened during the last daylight saving change where US and EU where not changing the same week.
bastelfreak
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time Zones are a PITA, the meeting incidentally happen at 15:30 UTC at the moment, but it is in reality scheduled at 16:30 CET (UTC+1) during the winter and 16:30 CEST (UTC+2) when daylight saving take place during the summer. Fix the indication so that it matches reality.
Because converting from one time-zone to an other is something nobody like to do, add some JavaScript code to do it for us and display when the next monthly sync will take place. For this we rely on moment.js to do the math (as everybody knows, JS sucks and it lacks some time-zone functions) and format the time of the event conveniently for the user in their time zone (with formatting such as "Tomorrow at 5:30 AM" when the date is near).
Last, but not least, provide a .ics file with the same information one more time so that people can easily choose what they prefer. Compared to the event in the Puppetlabs calendar, this one supposedly has the correct time-zone and should avoid the mess that happened during the last daylight saving change where US and EU where not changing the same week.