Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.5.0 #224

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Release 3.5.0 #224

merged 1 commit into from
Sep 13, 2021

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues


**Merged pull requests:**

- Migrate static data from hiera to init.pp [\#221](https://github.com/voxpupuli/puppet-systemd/pull/221) ([bastelfreak](https://github.com/bastelfreak))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to wake up, but we should consider how we classify this. I think technically this can be breaking for some users. To verify this: previously you could do lookup('systemd::$VAR') even if the module wasn't included from other modules. Now you can't. This is probably not used a lot, but it can break some use cases. That's why I think puppetlabs/puppet-strings#273 would be a better long term solution, but I don't have time to finish it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the puppet-strings PR would be the better approach, I also have that on my todo list since years but no time/not enough knowledge. Do you think we should here do a major release instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to avoid that, but we should keep it in mind.

CHANGELOG.md Outdated Show resolved Hide resolved
@bastelfreak bastelfreak merged commit 973582e into voxpupuli:master Sep 13, 2021
@bastelfreak bastelfreak deleted the rel350 branch September 13, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants