Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulesync 7.2.0 #198

Merged
merged 4 commits into from
Jan 9, 2024
Merged

modulesync 7.2.0 #198

merged 4 commits into from
Jan 9, 2024

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented May 12, 2023

No description provided.

@ekohl ekohl changed the title modulesync 6.0.0 modulesync 7.2.0 Jan 8, 2024
@ekohl ekohl force-pushed the modulesync branch 2 times, most recently from cc6e4fd to 0d56a5b Compare January 8, 2024 19:17
@ekohl
Copy link
Member

ekohl commented Jan 8, 2024

Well, this is a bug in beaker_puppet_helpers with quoting:

 Failure/Error: install_puppet_module_via_pmt_on(host, 'puppet-epel', '>= 3.0.1 < 4.0.0') if fact_on(host, 'os.name') == 'CentOS'
Beaker::Host::CommandFailure:
  Host 'centos7-64-puppet7.example.com' exited with 1 running:
   puppet module --version=>= 3.0.1 < 4.0.0 install puppet-epel
  Last 10 lines of output were:
  	bash: 4.0.0: No such file or directory

@ekohl
Copy link
Member

ekohl commented Jan 8, 2024

voxpupuli/beaker_puppet_helpers#40 should fix that.

install_module_from_forge('puppet-epel', '>= 3.0.1 < 4.0.0') if fact_on(host, 'os.name') == 'CentOS'
install_module_from_forge('puppetlabs-apache', '>= 5.7.0 < 7.0.0')
install_module_from_forge('puppetlabs-java', '>= 6.3.0 < 8.0.0')
install_puppet_module_via_pmt_on(host, 'puppet-epel', '>= 3.0.1 < 4.0.0') if fact_on(host, 'os.name') == 'CentOS'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OracleLinux is failing because it's not installing the EPEL module here. That was also an issue previously, so it's not a regression. Just wondering how this ever worked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a high chance that when the tests passed the last time, acceptance tests weren't enabled for OracleLinux?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, that's very likely.

@ekohl
Copy link
Member

ekohl commented Jan 9, 2024

Now includes #204 to drop OracleLinux, since it failed in testing.

@ekohl ekohl merged commit fb67acb into master Jan 9, 2024
9 checks passed
@ekohl ekohl deleted the modulesync branch January 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants