Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Debian 9, Ubuntu 16.04 and 18.04, FreeBSD 11, add support for Puppet 8, add support for RHEL 9 #453

Merged
merged 31 commits into from
Sep 21, 2023
Merged

Drop support for Debian 9, Ubuntu 16.04 and 18.04, FreeBSD 11, add support for Puppet 8, add support for RHEL 9 #453

merged 31 commits into from
Sep 21, 2023

Conversation

bastelfreak
Copy link
Member

modulesync 5.1.0

@smortex smortex force-pushed the modulesync branch 6 times, most recently from a88b8a4 to 4e5ea38 Compare January 19, 2022 01:27
@bastelfreak
Copy link
Member Author

@smortex looks like CentOS has some package conflicts. Is nodejs still supported there / did we setup the wrong repo / is epel broken maybe?

@smortex smortex mentioned this pull request Jan 19, 2022
Merged
@root-expert
Copy link
Member

Possibly NodeJS on EPEL is dead?

@smortex
Copy link
Member

smortex commented Jan 20, 2022

I don't see nodejs-<version>.rpm (only nodejs-<module>-<version>.rpm) on https://mirror.aarnet.edu.au/pub/epel/7/x86_64/Packages/n/ but see it on https://ftp-stud.hs-esslingen.de/pub/Mirrors/archive.fedoraproject.org/epel/6/x86_64/Packages/n/ so maybe yes 🤷

I guess we just have to axe it in a new breaking change PR.

@bastelfreak bastelfreak changed the title modulesync 5.1.0 modulesync 5.3.0 May 30, 2022
@bastelfreak bastelfreak force-pushed the modulesync branch 2 times, most recently from 963287e to 0929e91 Compare May 30, 2022 11:03
@bastelfreak
Copy link
Member Author

Hey @sircubbi , do you have any ideas why the tests on CentOS 7 do not pass?

@sircubbi
Copy link
Contributor

Hey @sircubbi , do you have any ideas why the tests on CentOS 7 do not pass?

Hmmm, nothing really catches my eye. Seems like some timeout while still setting up the docker-environment, but no specific cause I fear.

@bastelfreak
Copy link
Member Author

@sircubbi nownthe CI finally failed "properly", adter several docker-related issues. could you take a look again?

@sircubbi
Copy link
Contributor

@sircubbi nownthe CI finally failed "properly", adter several docker-related issues. could you take a look again?

It seems that /usr/bin/npm is not found. If you pull nodejs from EPEL you would also need to install the npm-Package from epel too (when using nodesource that is not necessary, since the npm-Command is already provided by the base-Package).

@prolixalias prolixalias mentioned this pull request Nov 4, 2022
Closed
@kenyon kenyon mentioned this pull request Jun 21, 2023
Closed
@kenyon kenyon changed the title modulesync 5.3.0 modulesync 7.0.0 Sep 16, 2023
@kenyon
Copy link
Member

kenyon commented Sep 17, 2023

I'll work on the EPEL failures. I can clean up the commit log once the code is good and the tests pass.

@kenyon kenyon force-pushed the modulesync branch 2 times, most recently from 905f6c7 to 4295a08 Compare September 17, 2023 21:17
kenyon added 14 commits September 20, 2023 20:58
@kenyon
shared examples: remove 'an idempotent resource'
a7ba1a8 
Use the shared example provided by
https://github.com/voxpupuli/voxpupuli-acceptance/blob/730a129a9b5a9fc660f016e74e67dc3be9b4968a/lib/voxpupuli/acceptance/examples.rb
instead.

This also removes test code for EOL Debian-family.
@kenyon
README: formatting fixes
df346f4
@kenyon
change default package ensure value to installed
1c7ba23 
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
@kenyon
README: remove parameter docs
3d37bac 
Use the autogenerated REFERENCE.md instead.
@kenyon
params: drop logic for EOL Debian-family OSes
42da865
@kenyon
params: collapse identical RedHat-family cases
303fa09
@kenyon
remove obsolete top-level class syntax
f98ff7a
@kenyon
fix acceptance tests
bb990d9 
Don't care where the packages come from on RedHat. Test installing npm
and the nodejs dev package on RedHat.

Run the global_config_entry tests on all OSes, not just RedHat. Don't
do redundant package checks within these contexts.

Arrange the config entry and package tests near each other.
@kenyon
remove unit test code for EOL Debian and Ubuntu versions
be87721
@kenyon
nodejs_spec: fix formatting
f86c889
@kenyon
acceptance test cleanup: use purged instead of absent
950a9b8 
Due to Puppet's use of rpm --erase with ensure=>absent, it can't
remove packages with reverse dependencies. Using ensure=>purged forces
Puppet to use dnf to remove packages instead of rpm.
@kenyon
acceptance: don't try installing nodejs-devel on RedHat
900bdd0 
nodejs-devel is version 16.18, but nodejs is version 16.20, so the
package management system won't allow them both to be installed.
@kenyon
README: Limitations section: refer to metadata.json
048847e
@kenyon
acceptance tests: replace deprecated install_module_from_forge
3d8b2e9 
install_module_from_forge is from the deprecated gem
https://github.com/voxpupuli/beaker-module_install_helper/ which was
replaced by https://github.com/voxpupuli/beaker_puppet_helpers.
@kenyon kenyon merged commit 78e933d into master Sep 21, 2023
22 checks passed
@kenyon kenyon deleted the modulesync branch September 21, 2023 04:11
@evgeni
Copy link
Member

evgeni commented Sep 25, 2023

This PR contains non modulesync changes:

How do I teach GHC that…

@evgeni evgeni changed the title modulesync 7.0.0 Drop support for Debian 9, Ubuntu 16.04 and 18.04, FreeBSD 11, add support for Puppet 8, add support for RHEL 9 Sep 25, 2023
@kenyon
Copy link
Member

kenyon commented Sep 25, 2023

Yeah, there were pull requests closed for those, so not sure why GHC didn't include them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bastelfreak @root-expert @smortex @sircubbi @kenyon @evgeni @maxadamo @cmd-ntrf @trevorrea