don't set npm_package_name when managerepo is true

nodesource started adding "provides: npm" to their nodejs packages, which makes our code uninstall the nodejs package again
voxpupuli · Oct 27, 2023 · b52fe8a · b52fe8a
1 parent 4fa73d3
commit b52fe8a
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/manifests/params.pp b/manifests/params.pp
@@ -27,7 +27,10 @@
       $nodejs_dev_package_ensure = 'absent'
       $nodejs_package_name       = 'nodejs'
       $npm_package_ensure        = 'absent'
-      $npm_package_name          = 'npm'
+      $npm_package_name          = $nodejs::manage_package_repo ? {
+        true    => false,
+        default => 'npm',
+      }
       $npm_path                  = '/usr/bin/npm'
       $repo_class                = 'nodejs::repo::nodesource'
       $package_provider          = undef
@@ -39,7 +42,10 @@
       $nodejs_dev_package_ensure = 'absent'
       $nodejs_package_name       = 'nodejs'
       $npm_package_ensure        = 'absent'
-      $npm_package_name          = 'npm'
+      $npm_package_name          = $manage_package_repo ? {
+        true    => false,
+        default => 'npm',
+      }
       $npm_path                  = '/usr/bin/npm'
       $repo_class                = 'nodejs::repo::nodesource'
       $package_provider          = undef