-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jenkins plugins fact develop vrt #1049
Closed
zipkid
wants to merge
18
commits into
voxpupuli:master
from
vrtdev:feature/jenkins_plugins_fact_develop_vrt
Closed
Feature/jenkins plugins fact develop vrt #1049
zipkid
wants to merge
18
commits into
voxpupuli:master
from
vrtdev:feature/jenkins_plugins_fact_develop_vrt
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debian, the service is started automatically on installation and this breaks changing the home directory of the jenkins user. If we create the user and homefolder before installing, this works like expected.
based on this PR: voxpupuli#945 We should probably use upstream fix for this once available.
… we want a different realm.
the if check to see if the user exists seems to be enough.
Fix/jenkins credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR changes the jenkins_plugins fact from a simple string value to a structured fact to avoid the error about a fact value being too long.
This Pull Request (PR) fixes the following issues
Fixes #1048
Maybe this gives too much information as the Hash contains much more than the name and version number that was in the 'old' fact.
It could easily be reduced to only some keys.