-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent Unknown resource type error (issue #35) #36
base: master
Are you sure you want to change the base?
Conversation
Hi @ttoohey, thanks for this patch. Are you able to provide a unit test to prove that this now compiles? |
It looks like #10 was completely broken when merged. Looks like a rebase or merge from master went wrong and undid part of the changes. |
I think the issue was #7 and #10 both were trying to fix the same issue. This PR undoes part of #10, but also leaves parts of it behind. Maybe we just revert #10 completely? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer reverting #10 ?
@bastelfreak ?
@bastelfreak - I'd like to have included a unit test, but I couldn't get past an error when trying to @alexjfisher - yes, #37 solves my problem. I'm not sure it will solve what #10 was attempting (but this PR probably doesn't either). |
Dear @ttoohey, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Dear @ttoohey, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
No description provided.