Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the praefect option #372

Closed
wants to merge 2 commits into from
Closed

Conversation

rudexi
Copy link

@rudexi rudexi commented Dec 17, 2020

Pull Request (PR) description

Support for the praefect option in gitlab omnibus configuration.

Reference:
https://docs.gitlab.com/ee/administration/gitaly/praefect.html#praefect

This Pull Request (PR) fixes the following issues

Fixes partially #366

@rudexi
Copy link
Author

rudexi commented Dec 17, 2020

It looks like the acceptance testing for CentOS 6 is failing.
This is not related to the change, but rather the repos for CentOS 6 need a fix.
Dropping CentOS 6 support could be a workaround.

References:
voxpupuli/puppet-redis#381
voxpupuli/voxpupuli.github.io#232

@smortex
Copy link
Member

smortex commented Aug 27, 2021

@rudexi Support for EOL OS was removed and the CI now works with GitLab 14.

Do you mind rebasing your changes on top of the master branch?

From your working directory:

git fetch origin         # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git push -f              # Send the changes (-f is required because we re-wrote history)

@smortex
Copy link
Member

smortex commented Aug 27, 2021

Also note that you can skip updating REFERENCE.md: it often cause conflicts when we are dealing with multiple PRs that compete to update it; and we regenerate it when we roll a new release.

@baurmatt
Copy link
Contributor

Hey @rudexi, are you still interested in getting this merged?

danielgriggs pushed a commit to danielgriggs/puppet-gitlab that referenced this pull request Nov 10, 2023
talseth pushed a commit to talseth/puppet-gitlab that referenced this pull request Apr 5, 2024
talseth pushed a commit to talseth/puppet-gitlab that referenced this pull request Apr 5, 2024
@smortex smortex closed this in #433 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants