firewalld_zone: Fix failure creating new zone #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly due to a change in recent firewalld versions, creating a new zone fails with: > Debug: Firewalld_zone[test3](provider=firewall_cmd): Creating new zone test3 with target: '' > Debug: Puppet::Type::Firewalld_zone::ProviderFirewall_cmd: Executing --state command - current value > Debug: Executing: '/usr/sbin/firewall-cmd --state' > Debug: Executing: '/usr/sbin/firewall-offline-cmd --new-zone test3' > Debug: Puppet::Type::Firewalld_zone::ProviderFirewall_cmd: Executing --state command - current value > Debug: Executing: '/usr/sbin/firewall-cmd --state' > Debug: Executing: '/usr/sbin/firewall-offline-cmd --zone test3 --list-interfaces' > Debug: Firewalld_zone[test3](provider=firewall_cmd): removing icmp block inversion for zone test3 > Debug: Puppet::Type::Firewalld_zone::ProviderFirewall_cmd: Executing --state command - current value > Debug: Executing: '/usr/sbin/firewall-cmd --state' > Debug: Executing: '/usr/sbin/firewall-offline-cmd --zone test3 --remove-icmp-block-inversion' > Error: Execution of '/usr/sbin/firewall-offline-cmd --zone test3 --remove-icmp-block-inversion' returned 12: > Error: /Stage[main]/Main/Firewalld_zone[test3]/ensure: change from 'absent' to 'present' failed: Execution of '/usr/sbin/firewall-offline-cmd --zone test3 --remove-icmp-block-inversion' returned 12: which seems to be because ICMP block inversion is unset by default: ``` > /usr/sbin/firewall-offline-cmd --zone test3 --remove-icmp-block-inversion NOT_ENABLED: icmp-block-inversion > echo $? 12 ``` Only manage `icmp_block_inversion` property on new zones if set to `true`.
|
I think the test failures look related @trevor-vaughan can you help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Possibly due to a change in recent firewalld versions (I'm on 2.1.1), creating a new zone fails with:
which seems to be because ICMP block inversion is unset by default:
Only manage
icmp_block_inversionproperty on new zones if set totrue.This Pull Request (PR) fixes the following issues
None. This is a report and fix all in one. Feel free to suggest changes.