Merge pull request #377 from jcpunk/missing-require

Add missing explicit require on Package
voxpupuli · Sep 11, 2024 · 9767cbe · 9767cbe
2 parents 9ce513a + e7854d5
commit 9767cbe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -178,8 +178,9 @@
   }
 
   service { 'firewalld':
-    ensure => $service_ensure,
-    enable => $service_enable,
+    ensure  => $service_ensure,
+    enable  => $service_enable,
+    require => Package[$package],
   }
 
   #...ipsets

diff --git a/spec/classes/init_spec.rb b/spec/classes/init_spec.rb
@@ -33,7 +33,8 @@
           it {
             is_expected.to contain_service('firewalld').
               with_ensure('running').
-              with_enable(true)
+              with_enable(true).
+              with_require('Package[firewalld]')
           }
 
           it { is_expected.not_to contain_augeas('firewalld::firewallbackend') }