Rubocop -A

lib/puppet/provider/firewalld_custom_service/firewall_cmd.rb

@@ -218,7 +218,7 @@ def destinations
     return @destinations if @destinations
 
     @destinations = execute_firewall_cmd(['--service', @resource[:name], '--get-destinations'], nil).strip.split(%r{\s+})
-    @destinations = @destinations.map { |x| x.split(':', 2) }.to_h
+    @destinations = @destinations.to_h { |x| x.split(':', 2) }
 
     @destinations
   end

lib/puppet/provider/firewalld_policy/firewall_cmd.rb

@@ -43,7 +43,7 @@ def target
     policy_target
   end
 
-  def target=(_t)
+  def target=(__target)
     debug("Setting target for policy #{@resource[:name]} to #{@resource[:target]}")
     execute_firewall_cmd_policy(['--set-target', @resource[:target]])
   end

lib/puppet/provider/firewalld_zone/firewall_cmd.rb

@@ -42,7 +42,7 @@ def target
     zone_target
   end
 
-  def target=(_t)
+  def target=(__target)
     debug("Setting target for zone #{@resource[:name]} to #{@resource[:target]}")
     execute_firewall_cmd(['--set-target', @resource[:target]])
   end

lib/puppet/type/firewalld_ipset.rb

@@ -13,10 +13,10 @@
         }
   "
 
-  def po2?(n)
+  def po2?(num)
     # A power of two value in binary representation only has one "1" in it.
     # ie. 01 10, 100 etc. are all power of 2.
-    n.to_s(2).count('1') == 1
+    num.to_s(2).count('1') == 1
   end
 
   ensurable do

lib/puppet/type/firewalld_policy.rb

@@ -204,7 +204,7 @@ def validate_zone_list(attr)
 
     raise Puppet::Error, "parameter #{attr} must be an array of strings!" unless self[attr].is_a?(Array)
 
-    raise Puppet::Error, "parameter #{attr} must contain at least one zone!" if self[attr].length.zero?
+    raise Puppet::Error, "parameter #{attr} must contain at least one zone!" if self[attr].empty?
 
     self[attr].each do |element|
       case element

spec/classes/init_spec.rb

@@ -260,7 +260,7 @@
       it do
         is_expected.to contain_exec('firewalld::set_log_denied').with(
           command: "firewall-cmd --set-log-denied #{cond} || firewall-offline-cmd --set-log-denied #{cond}",
-          unless: "[ \$\(firewall-cmd --get-log-denied || firewall-offline-cmd --get-log-denied) = #{cond} ]"
+          unless: "[ $(firewall-cmd --get-log-denied || firewall-offline-cmd --get-log-denied) = #{cond} ]"
         ).that_requires('Service[firewalld]')
       end
     end

spec/unit/puppet/provider/firewalld_custom_service_spec.rb

@@ -55,13 +55,13 @@
       provider.expects(:execute_firewall_cmd).with(['--get-services'], nil).returns("#{resource[:name]} foo bar baz")
       provider.expects(:execute_firewall_cmd).with(['--path-service', resource[:name]], nil).returns('/etc/foo_bar_baz.xml')
 
-      expect(provider.exists?).to eq true
+      expect(provider.exists?).to be true
     end
 
     it 'does not exist when not returned by the system' do
       provider.expects(:execute_firewall_cmd).with(['--get-services'], nil).returns('foo bar baz')
 
-      expect(provider.exists?).to eq false
+      expect(provider.exists?).to be false
     end
   end
 

spec/unit/puppet/type/firewalld_policy_spec.rb

@@ -78,8 +78,8 @@
             described_class.new(name: 'bad ingress_zones',
                                 ingress_zones: [symbolic_zone, 'public'],
                                 egress_zones: ['restricted'])
-          end.to raise_error(%r{parameter ingress_zones must contain a single symbolic zone or one or more regular zones})
-        end
+          end
+        end.to raise_error(%r{parameter ingress_zones must contain a single symbolic zone or one or more regular zones})
       end
 
       it 'rejects bad egress_zones combinations' do
@@ -88,8 +88,8 @@
             described_class.new(name: 'bad egress_zones',
                                 ingress_zones: ['public'],
                                 egress_zones: [symbolic_zone, 'restricted'])
-          end.to raise_error(%r{parameter egress_zones must contain a single symbolic zone or one or more regular zones})
-        end
+          end
+        end.to raise_error(%r{parameter egress_zones must contain a single symbolic zone or one or more regular zones})
       end
 
       it 'accepts lone symbolic ingress_zones' do