Fixup ICMP tests and set defaults #57
jcpunk
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
ci.yml
on: pull_request
Puppet
/
Static validations
20s
Matrix: Puppet / acceptance
Matrix: Puppet / unit
Puppet
/
Test suite
0s
Annotations
3 errors
|
Puppet / Static validations:
lib/puppet/provider/firewalld_zone/firewall_cmd.rb#L115
Style/IfUnlessModifier: Favor modifier `unless` usage when having a single-line body. Another good alternative is the usage of control flow `&&`/`||`. (https://rubystyle.guide#if-as-a-modifier)
|
|
Puppet / Static validations:
lib/puppet/provider/firewalld_zone/firewall_cmd.rb#L144
Lint/RedundantCopDisableDirective: Unnecessary disabling of `Style/GuardClause`.
|
|
Puppet / Static validations
Process completed with exit code 1.
|