Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata versions #28

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Update metadata versions #28

merged 1 commit into from
Aug 12, 2019

Conversation

pillarsdotnet
Copy link
Contributor

@pillarsdotnet pillarsdotnet commented Aug 1, 2019

Apparently it is not possible for the tests to pass.

@pillarsdotnet pillarsdotnet changed the title Update versions in metadata.json Update metadata versions Aug 2, 2019
@pillarsdotnet pillarsdotnet reopened this Aug 2, 2019
@pillarsdotnet pillarsdotnet reopened this Aug 2, 2019
@ninaspitfire
Copy link
Contributor

ninaspitfire commented Aug 5, 2019

This looks good, thanks!

I don't know what's wrong with Travis, but the changes in your first commit pass just fine when I run the tests locally. If you'd be kind enough to change this PR back to just your initial commit, I'll gladly merge it.

Cheers.

@pillarsdotnet
Copy link
Contributor Author

Done.

@pillarsdotnet
Copy link
Contributor Author

@Jarpy Still awaiting merge.

@ninaspitfire
Copy link
Contributor

Thanks! I'll cut a new release for this now.

@ninaspitfire ninaspitfire merged commit be772e1 into voxpupuli:master Aug 12, 2019
@pillarsdotnet
Copy link
Contributor Author

Thanks, @Jarpy

While you're at it, I have related PR's (with similar unrelated failures) awaiting review:

@pillarsdotnet pillarsdotnet deleted the patch-1 branch August 12, 2019 13:23
@ninaspitfire
Copy link
Contributor

Released in 6.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants