Adding a Ruby based Puppet task that checks for which .NET versions ar… #70
Conversation
|
Cleaned up Ruby formatting warnings with Rubocop. How can I get the Travis CI checks to run again? |
|
Temporarily closing and re-opening to kick off a new build. |
Further rubocop style updates
|
Additional updates to syntax made to pass Rubocop checks. Closing and re-opening to kick off the Travis CI jobs again. |
More Rubocop style changes.
|
OK. Apologies for the noise with all the commits and re-opening. (Looks like I didn't need to close and re-open, just push to origin again) The one piece I'm unsure about is documentation of the new task in the README.md. I was going to make changes but wasn't sure where the preferred place to make them would be. Any guidance there would be appreciated. Running the task is easy as invoking "bolt script run regcheck.rb" on a set of target nodes. |
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "description": "Query which .NET versions are installed on Windows Server(s)." | |||
There was a problem hiding this comment.
Is this limited to servers or does it work on desktops too?
There was a problem hiding this comment.
Should work on all recent Windows OS versions as far as this article is concerned: https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed
|
It looks to me like an update to the readme should be added to this too. |
@genebean agreed. I just wasn't quite sure whether to create a separate Tasks section in the Readme file or the best place to put it? So looking for some guidance from other contributors before I make any changes to it. |
Added task information to Readme file
|
Ping. Any comments on this task or what it might take to get it merged? |
…e installed
Pull Request (PR) description
This Pull Request (PR) fixes the following issues