-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove java 1.8 support #242
base: master
Are you sure you want to change the base?
remove java 1.8 support #242
Conversation
cab71ef
to
2717828
Compare
version => '5.5.6', | ||
jvm_type => 'oracle-jdk-1.8', | ||
version => '8.5.12', | ||
jvm_type => 'openjdk-11', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like my change to the archive resource above in 2a4bfcc is incomplete ...
Title 'jdk11' but it downloads zulu jdk8.
@@ -6,7 +6,7 @@ | |||
|
|||
# JVM Settings | |||
$javahome = undef, | |||
Enum['openjdk-11', 'oracle-jdk-1.8', 'custom'] $jvm_type = 'openjdk-11', | |||
Enum['openjdk-11', 'custom'] $jvm_type = 'openjdk-11', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$version still defaults to 5.7.1. Is 5.7.1 still supported by atlassian? Does it support running on jdk11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked into this now.
According to https://confluence.atlassian.com/support/atlassian-support-end-of-life-policy-201851003.html 7.19 is the oldest supported version with EOL 13 Dec 2024
Since 7.x is still supported on java8 and Oracle continue to support java8 for paying customers https://www.oracle.com/java/technologies/java-se-support-roadmap.html it's a bit to early to remove support in the module.
2717828
to
7d94fe2
Compare
The acceptance tests btw is failing because the href in the welcome screen has been changed from http to https. |
When it comes to testing confluence versions I think we should adopt https://github.com/voxpupuli/voxpupuli-acceptance/blob/5b396938f5fd7c3f190fe78550913caafffdb39d/README.md?plain=1#L149 and test all supported major.minor.latest releases. Example of adding this to CI as well: |
java 1.8 is unsupported for a long long time. the tests are something which needs a deeper look. titles don't fit the java version actually installed