validate checksum_url attribute #472
Conversation
pillarsdotnet
force-pushed
the
471-fix-docs
branch
from
a2c50e8
to
a4f4c6d
Compare
bastelfreak
changed the title
lib/puppet/type/archive.rb
Outdated
| desc 'archive file checksum source (instead of specifying checksum). Supports http|https|ftp|file' | ||
| validate do |value| | ||
| unless value =~ URI.regexp(%w[http https ftp file]) | ||
| raise ArgumentError, "invalid source url: #{value}" |
There was a problem hiding this comment.
thanks for adding the validation, could you add a test here? https://github.com/voxpupuli/puppet-archive/blob/master/spec/unit/puppet/type/archive_spec.rb
There was a problem hiding this comment.
Turns out that it doesn't work for file:/// urls. Not sure if it will work for ftp:// urls and can't test locally as we don't have an ftp server. It doesn't seem to take absolute-paths either. It would be nice if the checksum_url attribute would accept the same range of inputs that the source attribute does, but implementing that change is out-of-scope for my current project.
There was a problem hiding this comment.
I may just close this PR and leave the issue open; I've already spent way more billable hours on this than I should have.
pillarsdotnet
force-pushed
the
471-fix-docs
branch
from
a4f4c6d
to
8dc0f4e
Compare
pillarsdotnet
force-pushed
the
471-fix-docs
branch
from
8dc0f4e
to
c65099b
Compare
pillarsdotnet
changed the title
pillarsdotnet
changed the title
Pull Request (PR) description
Adds missing docs and validation for the
checksum_urlattribute.This Pull Request (PR) fixes the following issues
Fixes #471