Do not attempt to install curl on DNF-based distros #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNF depends on curl or curl-minimal. It's not needed to explicitly install this. This simplifies things.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
+ Coverage 74.52% 74.53% +0.01%
==========================================
Files 81 81
Lines 4506 4504 -2
==========================================
- Hits 3358 3357 -1
+ Misses 1148 1147 -1 ☔ View full report in Codecov by Sentry. |
bastelfreak
approved these changes
Mar 13, 2024
Merged
kenyon
added a commit
to kenyon/beaker
that referenced
this pull request
Aug 27, 2024
curl-minimal was mistakenly added in commit 18e6e22. curl is installed by default. See https://fedoraproject.org/wiki/Changes/CurlMinimal_as_Default and voxpupuli#1854, for example.
kenyon
added a commit
to kenyon/beaker
that referenced
this pull request
Aug 27, 2024
curl-minimal was mistakenly added in commit 18e6e22. Attempting to install it on EL 8 and newer causes errors because there is no such package. curl is installed by default. See https://fedoraproject.org/wiki/Changes/CurlMinimal_as_Default and voxpupuli#1854, for example.
kenyon
added a commit
to kenyon/beaker
that referenced
this pull request
Aug 27, 2024
curl-minimal was mistakenly added in commit 18e6e22. Attempting to install it on EL 8 and newer causes errors because there is no such package. curl is installed by default. See https://fedoraproject.org/wiki/Changes/CurlMinimal_as_Default and voxpupuli#1854, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNF depends on curl or curl-minimal. It's not needed to explicitly install this. This simplifies things.