Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5938) Add support for Debian 12 - 14 & Amazon Linux 2023 in beaker 4.x #1829

Closed
wants to merge 3 commits into from

Conversation

shubhamshinde360
Copy link

No description provided.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9c0721f) 74.91% compared to head (337eefa) 74.94%.

❗ Current head 337eefa differs from pull request most recent head 1685601. Consider uploading reports for the commit 1685601 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #1829      +/-   ##
==========================================
+ Coverage   74.91%   74.94%   +0.03%     
==========================================
  Files          82       82              
  Lines        4863     4865       +2     
==========================================
+ Hits         3643     3646       +3     
+ Misses       1220     1219       -1     
Files Coverage Δ
lib/beaker/host/unix/exec.rb 73.30% <ø> (ø)
lib/beaker/host/unix/file.rb 90.90% <ø> (ø)
lib/beaker/host/unix/pkg.rb 67.02% <100.00%> (ø)
lib/beaker/host_prebuilt_steps.rb 74.83% <100.00%> (+0.50%) ⬆️
lib/beaker/platform.rb 100.00% <100.00%> (ø)
lib/beaker/perf.rb 56.45% <66.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekohl ekohl changed the title (PA-5938) Add support for Debian 11 & Amazon Linux 2023 in beaker 4.x (PA-5938) Add support for Debian 12 - 14 & Amazon Linux 2023 in beaker 4.x Nov 8, 2023
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding, will Amazon Linux also be its own OS family in Facter now or is it still considered a member of the Red Hat family? I know it's now Fedora derived, so it probably still is. Just no longer really close to RHEL + derivatives.

lib/beaker/host_prebuilt_steps.rb Show resolved Hide resolved
@bastelfreak
Copy link
Member

@shubhamshinde360 are there plans to move to beaker 5? We don't really have guidelines for projects with to maintained branches and beaker is currently the only project where we do this. It would be nice if we could get rid of it in the long term.

@ekohl
Copy link
Member

ekohl commented Nov 8, 2023

Updating to Beaker 5 would be preferred, but I don't mind maintaining a stable branch for a bit. If possible, it would be great to land the patches in master first and then use git cherry-pick -x on those so the history is clear. And we don't regress.

@shubhamshinde360
Copy link
Author

Hi @bastelfreak,
Our CI is using beaker 4 currently and it would be a time consuming tasks to migrate to beaker 5.
We are having discussions around the migration. But as a workaround we made this cherry-pick to test out amazon 2023 platform addition to puppet-agent.

@shubhamshinde360
Copy link
Author

Closing this PR since it is a duplicate of #1828

@bastelfreak
Copy link
Member

@shubhamshinde360 this is totally fine for now, because of that the 4.x branch exists, but in the long term it would be nice if we could get rid of it. Otherwise it diverges too much from the master branch and an upgrade just gets more painful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants