-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PA-5938) Add support for Debian 12 - 14 & Amazon Linux 2023 in beaker 4.x #1829
Conversation
9270286
to
ca0fec0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 4.x #1829 +/- ##
==========================================
+ Coverage 74.91% 74.94% +0.03%
==========================================
Files 82 82
Lines 4863 4865 +2
==========================================
+ Hits 3643 3646 +3
+ Misses 1220 1219 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding, will Amazon Linux also be its own OS family in Facter now or is it still considered a member of the Red Hat family? I know it's now Fedora derived, so it probably still is. Just no longer really close to RHEL + derivatives.
@shubhamshinde360 are there plans to move to beaker 5? We don't really have guidelines for projects with to maintained branches and beaker is currently the only project where we do this. It would be nice if we could get rid of it in the long term. |
ca0fec0
to
7431d51
Compare
Updating to Beaker 5 would be preferred, but I don't mind maintaining a stable branch for a bit. If possible, it would be great to land the patches in |
…disabling of Layout/Linelength
Hi @bastelfreak, |
Closing this PR since it is a duplicate of #1828 |
@shubhamshinde360 this is totally fine for now, because of that the 4.x branch exists, but in the long term it would be nice if we could get rid of it. Otherwise it diverges too much from the master branch and an upgrade just gets more painful. |
No description provided.