Fix Minitest capitalization #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 4.x #1818 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 82 82
Lines 4863 4863
=======================================
Hits 3643 3643
Misses 1220 1220
☔ View full report in Codecov by Sentry. |
mhashizume
force-pushed
the
maint/4.x/minitest
branch
from
bcbb68e
to
0aabbe1
Compare
Minitest v5.19.0, released today, includes a commit[1] that only calls
its compatibility layer when using an environment variable
("MT_COMPAT").
This means that calling "MiniTest" (with a capital "T") instead of
"Minitest" (with all lowercase "T"s) no longer works.
This commit replaces all instances of "MiniTest" with "Minitest."
[1] minitest/minitest@a2c6c18
mhashizume
force-pushed
the
maint/4.x/minitest
branch
from
0aabbe1
to
7f9e73b
Compare
|
do we have to merge this into the 4.x branch? that's kinda dead and maintaining and releasing it is tricky. |
|
We're still using 4.x internally at Puppet, so a 4.x release would be much appreciated |
smortex
changed the title
Note for myself next time:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minitest v5.19.0, released today, includes a commit[1] that only calls its compatibility layer when using an environment variable ("MT_COMPAT").
This means that calling "MiniTest" (with a capital "T") instead of "Minitest" (with all lowercase "T"s) no longer works.
This commit replaces all instances of "MiniTest" with "Minitest."
[1] minitest/minitest@a2c6c18