Update based on voxpupuli/modulesync_config 0.14.1

.msync.yml

@@ -1 +1 @@
-modulesync_config_version: '0.13.0'
+modulesync_config_version: '0.14.1'

.rubocop.yml

@@ -57,6 +57,9 @@ Style/AndOr:
 Style/RedundantSelf:
   Enabled: True
 
+Metric/BlockLength:
+  Enabled: False
+
 # Method length is not necessarily an indicator of code quality
 Metrics/MethodLength:
   Enabled: False

Gemfile

@@ -25,9 +25,11 @@ group :test do
   gem 'metadata-json-lint',                                         :require => false
   gem 'puppet-blacksmith',                                          :require => false
   gem 'voxpupuli-release',                                          :require => false, :git => 'https://github.com/voxpupuli/voxpupuli-release-gem.git'
-  gem 'puppet-strings', '0.4.0',                                    :require => false
+  gem 'puppet-strings', '~> 0.99.0',                                :require => false
   gem 'rubocop-rspec', '~> 1.6',                                    :require => false if RUBY_VERSION >= '2.3.0'
   gem 'json_pure', '<= 2.0.1',                                      :require => false if RUBY_VERSION < '2.0.0'
+  gem 'mocha', '>= 1.2.1',                                          :require => false
+  gem 'coveralls',                                                  :require => false if RUBY_VERSION >= '2.0.0'
 end
 
 group :development do
@@ -45,6 +47,7 @@ group :system_tests do
   else
     gem 'beaker-rspec',  :require => false
   end
+  gem 'serverspec',                    :require => false
   gem 'beaker-puppet_install_helper',  :require => false
 end
 

Rakefile

@@ -1,7 +1,7 @@
 require 'puppetlabs_spec_helper/rake_tasks'
 require 'puppet_blacksmith/rake_tasks'
 require 'voxpupuli/release/rake_tasks'
-require 'puppet-strings/rake_tasks'
+require 'puppet-strings/tasks'
 
 PuppetLint.configuration.log_format = '%{path}:%{line}:%{check}:%{KIND}:%{message}'
 PuppetLint.configuration.fail_on_warnings = true

manifests/client.pp

@@ -35,12 +35,12 @@
 #   client_package    => 'bacula-client',
 # }
 class bacula::client(
+    $director_password,
+    $director_server,
     $client_conf = '/etc/bacula/bacula-fd.conf',
     $client_conf_template = 'bacula/bacula-fd.conf.erb',
     $client_package = 'bacula-client',
     $client_service = 'bacula-fd',
-    $director_password,
-    $director_server,
     $package_provider = undef,
     $pid_dir = '/var/run/bacula',
     $working_dir = '/var/lib/bacula'

manifests/common.pp

@@ -13,13 +13,13 @@
 class bacula::common (
   $packages,
   $manage_db_tables,
-  $manage_db         = true,
   $db_backend,
   $db_user,
   $db_database,
   $db_password,
   $db_port,
   $db_host,
+  $manage_db         = true,
   ) {
 
   $notify_database = $manage_db_tables ? {

manifests/director.pp

@@ -50,9 +50,9 @@
     $mysql_package,
     $mail_to,
     $sqlite_package,
-    $template = 'bacula/bacula-dir.conf.erb',
     $use_console,
     $console_password,
+    $template = 'bacula/bacula-dir.conf.erb',
     $clients = {}
 ) {
 

manifests/storage.pp

@@ -42,10 +42,10 @@
     $director_server,
     $director_password,
     $storage_server,
-    $storage_package = '',
     $mysql_package,
     $sqlite_package,
     $console_password,
+    $storage_package = '',
     $template = 'bacula/bacula-sd.conf.erb'
   ) {
 

spec/acceptance/nodesets/centos-511-x64.yml

@@ -1,4 +1,7 @@
 ---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
 HOSTS:
   centos-511-x64:
     roles:

spec/acceptance/nodesets/centos-66-x64-pe.yml

@@ -1,4 +1,7 @@
 ---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
 HOSTS:
   centos-66-x64:
     roles:

spec/acceptance/nodesets/centos-66-x64.yml

@@ -1,4 +1,7 @@
 ---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
 HOSTS:
   centos-66-x64:
     roles:

spec/acceptance/nodesets/centos-72-x64.yml

@@ -1,4 +1,7 @@
 ---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
 HOSTS:
   centos-72-x64:
     roles:

spec/acceptance/nodesets/debian-78-x64.yml

@@ -1,4 +1,7 @@
 ---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
 HOSTS:
   debian-78-x64:
     roles:

spec/acceptance/nodesets/debian-82-x64.yml

@@ -1,4 +1,7 @@
 ---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
 HOSTS:
   debian-82-x64:
     roles:

spec/acceptance/nodesets/docker/centos-5.yml

@@ -0,0 +1,22 @@
+---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
+HOSTS:
+  centos-5-x64:
+    default_apply_opts:
+      order: random
+      strict_variables:
+    platform: el-5-x86_64
+    hypervisor : docker
+    image: tianon/centos:5.10
+    docker_preserve_image: true
+    docker_cmd: '["/sbin/init"]'
+    docker_image_commands:
+      - 'yum install -y crontabs tar wget which'
+      - 'sed -i -e "/mingetty/d" /etc/inittab'
+CONFIG:
+  type: aio
+  log_level: debug
+...
+# vim: syntax=yaml

spec/acceptance/nodesets/docker/centos-6.yml

@@ -0,0 +1,23 @@
+---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
+HOSTS:
+  centos-6-x64:
+    default_apply_opts:
+      order: random
+      strict_variables:
+    platform: el-6-x86_64
+    hypervisor : docker
+    image: centos:6
+    docker_preserve_image: true
+    docker_cmd: '["/sbin/init"]'
+    docker_image_commands:
+      - 'rm -rf /var/run/network/*'
+      - 'yum install -y crontabs tar wget'
+      - 'rm /etc/init/tty.conf'
+CONFIG:
+  type: aio
+  log_level: debug
+...
+# vim: syntax=yaml

spec/acceptance/nodesets/docker/centos-7.yml

@@ -0,0 +1,21 @@
+---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
+HOSTS:
+  centos-7-x64:
+    default_apply_opts:
+      order: random
+      strict_variables:
+    platform: el-7-x86_64
+    hypervisor : docker
+    image: centos:7
+    docker_preserve_image: true
+    docker_cmd: '["/usr/sbin/init"]'
+    docker_image_commands:
+      - 'yum install -y crontabs tar wget iproute'
+CONFIG:
+  type: aio
+  log_level: debug
+...
+# vim: syntax=yaml

spec/acceptance/nodesets/docker/debian-7.yml

@@ -0,0 +1,21 @@
+---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
+HOSTS:
+  debian-7-x64:
+    default_apply_opts:
+      order: random
+      strict_variables:
+    platform: debian-7-amd64
+    hypervisor : docker
+    image: debian:7
+    docker_preserve_image: true
+    docker_cmd: '["/sbin/init"]'
+    docker_image_commands:
+      - 'apt-get install -y cron locales-all net-tools wget'
+CONFIG:
+  type: aio
+  log_level: debug
+...
+# vim: syntax=yaml

spec/acceptance/nodesets/docker/debian-8.yml

@@ -0,0 +1,22 @@
+---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
+HOSTS:
+  debian-8-x64:
+    default_apply_opts:
+      order: random
+      strict_variables:
+    platform: debian-8-amd64
+    hypervisor : docker
+    image: debian:8
+    docker_preserve_image: true
+    docker_cmd: '["/sbin/init"]'
+    docker_image_commands:
+      - 'apt-get install -y cron locales-all net-tools wget'
+      - 'rm -f /usr/sbin/policy-rc.d'
+CONFIG:
+  type: aio
+  log_level: debug
+...
+# vim: syntax=yaml

spec/acceptance/nodesets/docker/ubuntu-12.04.yml

@@ -0,0 +1,22 @@
+---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
+HOSTS:
+  ubuntu-1204-x64:
+    default_apply_opts:
+      order: random
+      strict_variables:
+    platform: ubuntu-12.04-amd64
+    hypervisor : docker
+    image: ubuntu:12.04
+    docker_preserve_image: true
+    docker_cmd: '["/sbin/init"]'
+    docker_image_commands:
+      - 'apt-get install -y net-tools wget'
+      - 'locale-gen en_US.UTF-8'
+CONFIG:
+  type: aio
+  log_level: debug
+...
+# vim: syntax=yaml

spec/acceptance/nodesets/docker/ubuntu-14.04.yml

@@ -0,0 +1,24 @@
+---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
+HOSTS:
+  ubuntu-1404-x64:
+    default_apply_opts:
+      order: random
+      strict_variables:
+    platform: ubuntu-14.04-amd64
+    hypervisor : docker
+    image: ubuntu:14.04
+    docker_preserve_image: true
+    docker_cmd: '["/sbin/init"]'
+    docker_image_commands:
+      - 'rm /usr/sbin/policy-rc.d'
+      - 'rm /sbin/initctl; dpkg-divert --rename --remove /sbin/initctl'
+      - 'apt-get install -y net-tools wget'
+      - 'locale-gen en_US.UTF-8'
+CONFIG:
+  type: aio
+  log_level: debug
+...
+# vim: syntax=yaml

spec/acceptance/nodesets/docker/ubuntu-16.04.yml

@@ -0,0 +1,22 @@
+---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
+HOSTS:
+  ubuntu-1604-x64:
+    default_apply_opts:
+      order: random
+      strict_variables:
+    platform: ubuntu-16.04-amd64
+    hypervisor : docker
+    image: ubuntu:16.04
+    docker_preserve_image: true
+    docker_cmd: '["/sbin/init"]'
+    docker_image_commands:
+      - 'apt-get install -y net-tools wget'
+      - 'locale-gen en_US.UTF-8'
+CONFIG:
+  type: aio
+  log_level: debug
+...
+# vim: syntax=yaml

spec/acceptance/nodesets/ubuntu-server-1204-x64.yml

@@ -1,4 +1,7 @@
 ---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
 HOSTS:
   ubuntu-server-1204-x64:
     roles:

spec/acceptance/nodesets/ubuntu-server-1404-x64.yml

@@ -1,4 +1,7 @@
 ---
+# This file is managed via modulesync
+# https://github.com/voxpupuli/modulesync
+# https://github.com/voxpupuli/modulesync_config
 HOSTS:
   ubuntu-server-1404-x64:
     roles: