Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Node.js 12 actions to 16 #69

Merged
merged 1 commit into from
Jan 3, 2023
Merged

bump Node.js 12 actions to 16 #69

merged 1 commit into from
Jan 3, 2023

Conversation

klamas1
Copy link

@klamas1 klamas1 commented Oct 12, 2022

Purpose

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: voxmedia/github-action-slack-notify-build

Important Changes

runs:
using: 'node16'

@klamas1 klamas1 mentioned this pull request Oct 12, 2022
@aariacarterweir
Copy link

yo pls can we get this merged? if not, @klamas1 would you be willing to fork?

@klamas1
Copy link
Author

klamas1 commented Oct 17, 2022

"1 workflow awaiting approval", waiting for one more

@john-doherty
Copy link

Is it possible to use this PR as a GitHub action?

@aariacarterweir
Copy link

aariacarterweir commented Oct 17, 2022 via email

@klamas1
Copy link
Author

klamas1 commented Oct 17, 2022

Write in the issue
#68

@clemblanco
Copy link

Bump up

@aariacarterweir
Copy link

Bump again

@aariacarterweir
Copy link

Are we able to get this merged please?

@AdmirHad
Copy link

Bumping the PR

@lfg-will
Copy link

This pull request has been approved for over a month now. Can we at least get a reason why? Otherwise I feel like I will need to migrate to an actively-maintained fork.

Copy link

@AdmirHad AdmirHad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@klamas1
Copy link
Author

klamas1 commented Nov 18, 2022

Enough Approves, We Need a Merge

"Only those with write access to this repository can merge pull requests."

@aariacarterweir
Copy link

Anyone know a good fork we can migrate to? This repo has clearly been abandoned.

@tallmanbrew
Copy link

Doesn't seem that the 3 people that have ever merged PR's work for voxmedia any longer.

@klamas1
Copy link
Author

klamas1 commented Nov 29, 2022

There doesn't seem to be any updates to this repo.
if you just want to use the notification action you can fork my version or use my repo directly
uses: klamas1/github-action-slack-notify-build@v3

@sstopkin
Copy link

@ealcantara22 @sixfoot6 @okor @maria-mata @nicolezhu Is there anybody from voxmedia, who able to just click the MERGE button? Thanks!

@ebinmore
Copy link
Contributor

ebinmore commented Jan 3, 2023

This repo has been abandon for different tooling internally. I will merge this PR. Moving forward, you should seriously consider maintaining your own fork or use someone else's like #69 (comment).

@ebinmore ebinmore merged commit 329bf14 into voxmedia:main Jan 3, 2023
@ebinmore ebinmore mentioned this pull request Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.