Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Rakuten Affiliate Link Consent URL Param #11

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

banderson623
Copy link
Contributor

Rakuten expect's user consent URL parameters to be added to affiliate links. This small generator will look for Rakuten affiliate links and add the usPrivacyString-like consent param. Notably: it requires the usPrivacyString generator being available.

From their docs, the link should be appended like this:
CleanShot 2020-08-10 at 06 11 06@2x

To make this work intent-oriented, not vendor specific, the functionality this generator framework supports is externally named: addConsentParameterToCommerceLinks and is called with:

PrivacyCompliance.Generator.addConsentParameterToCommerceLinks()

If you are reviewing this, I'd love some help thinking about:

  • Is this name right – to support additional commerce vendors and their consent requirements? Should it be less about consent requirements and more about privacy params? I am open to changing the name.
  • URL param addition – to avoid any URL processing and destructuring into path, params, ... I simply looked to see if ? is present in the link, and if so, append the param with & else use ?. Logically this feels okay, but I am sure there are some holes in it.

@banderson623 banderson623 requested review from walia, jplhomer and andrew-a-dev and removed request for walia and jplhomer August 10, 2020 13:31
Copy link
Contributor

@jplhomer jplhomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Brian! RE: both of your questions, I think the focus on consent params and the ? vs & logic is sound 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants