implement support for session storage in redis. #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of storing the JWT in a cookie, we store the date in redis and pass a session token to the client. this keeps the cookie size small no matter the amount of data in the session. related to #348
|
this is an implementation draft. it is still missing some documentation |
|
@UiP9AV6Y thanks for submitting this PR and for putting effort into Vouch Proxy as per the README this level change really deserves discussion before implementation and as a style choice I really prefer to do that in an issue. I'm going to close this PR, could you please open an issue related to this change? I'll link through to this PR from there. I do honestly appreciate the effort and look forward to the discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of storing the JWT in a cookie, we store the date in redis
and pass a session token to the client. this keeps the cookie size
small no matter the amount of data in the session.
related to #348