Update the DNS setting to be a mandatory configuration ... (openmedia…

…vault#1839) ... for both Ethernet and WiFi network interfaces when a gateway is set. There are simply too many posts in the forum that are due to users not configuring the DNS server when configuring static IP. Signed-off-by: Volker Theile <[email protected]>
votdev · Oct 26, 2024 · cb05b62 · cb05b62
1 parent 13e040d
commit cb05b62
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 2 deletions.
diff --git a/deb/openmediavault/debian/changelog b/deb/openmediavault/debian/changelog
@@ -1,6 +1,8 @@
 openmediavault (7.4.11-1) stable; urgency=low
 
   * Several improvements.
+  * Update the DNS setting to be a mandatory configuration for
+    both Ethernet and WiFi network interfaces.
   * Issue #1835: Unlink mount directory only if empty.
 
  -- Volker Theile <[email protected]>  Sat, 12 Oct 2024 12:13:43 +0200

diff --git a/...ault/workbench/src/app/pages/network/interfaces/interface-ethernet-form-page.component.ts b/...ault/workbench/src/app/pages/network/interfaces/interface-ethernet-form-page.component.ts
@@ -297,7 +297,20 @@ export class InterfaceEthernetFormPageComponent extends BaseFormPageComponent {
         hint: gettext('IP addresses of domain name servers used to resolve host names.'),
         value: '',
         validators: {
-          patternType: 'ipList'
+          patternType: 'ipList',
+          requiredIf: {
+            operator: 'or',
+            arg0: {
+              operator: 'and',
+              arg0: { operator: 'eq', arg0: { prop: 'method' }, arg1: 'static' },
+              arg1: { operator: 'n', arg0: { prop: 'gateway' } }
+            },
+            arg1: {
+              operator: 'and',
+              arg0: { operator: 'eq', arg0: { prop: 'method6' }, arg1: 'static' },
+              arg1: { operator: 'n', arg0: { prop: 'gateway6' } }
+            }
+          }
         }
       },
       {

diff --git a/...diavault/workbench/src/app/pages/network/interfaces/interface-wifi-form-page.component.ts b/...diavault/workbench/src/app/pages/network/interfaces/interface-wifi-form-page.component.ts
@@ -338,7 +338,20 @@ export class InterfaceWifiFormPageComponent extends BaseFormPageComponent {
         hint: gettext('IP addresses of domain name servers used to resolve host names.'),
         value: '',
         validators: {
-          patternType: 'ipList'
+          patternType: 'ipList',
+          requiredIf: {
+            operator: 'or',
+            arg0: {
+              operator: 'and',
+              arg0: { operator: 'eq', arg0: { prop: 'method' }, arg1: 'static' },
+              arg1: { operator: 'n', arg0: { prop: 'gateway' } }
+            },
+            arg1: {
+              operator: 'and',
+              arg0: { operator: 'eq', arg0: { prop: 'method6' }, arg1: 'static' },
+              arg1: { operator: 'n', arg0: { prop: 'gateway6' } }
+            }
+          }
         }
       },
       {