Skip to content

Commit

Permalink
Use subtree_check to reduce subtree attacks
Browse files Browse the repository at this point in the history
... in the NFSv4 pseudo file system export. This can be modified via the `OMV_NFSD_V4_PSEUDO_ROOT_OPTIONS` environment variable.

Signed-off-by: Volker Theile <[email protected]>
  • Loading branch information
votdev committed Aug 20, 2024
1 parent 854df05 commit 5d8bf75
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions deb/openmediavault/debian/changelog
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ openmediavault (7.4.6-1) stable; urgency=low
Congdi 2.5-Inch USB 3.1 Type-C hard drive enclosures.
* Add UDEV rule to fix the duplicate serial number issue for
Insignia 2-Bay HDD docking stations.
* Use `subtree_check` to reduce subtree attacks in the NFSv4
pseudo file system export. This can be modified via the
`OMV_NFSD_V4_PSEUDO_ROOT_OPTIONS` environment variable.

-- Volker Theile <[email protected]> Mon, 19 Aug 2024 19:26:45 +0200

Expand Down
3 changes: 3 additions & 0 deletions deb/openmediavault/debian/openmediavault.postinst
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,9 @@ case "$1" in
if dpkg --compare-versions "$2" lt-nl "7.4.5"; then
omv_module_set_dirty apticron
fi
if dpkg --compare-versions "$2" lt-nl "7.4.6"; then
omv_module_set_dirty nfs
fi

########################################################################
# Trigger the restart of the omv-engined daemon to load and use the
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{%- set separator = ' ' %}
{%- set export_dir = salt['pillar.get']('default:OMV_NFSD_EXPORT_DIR', '/export') -%}
{%- set pseudo_root_options = salt['pillar.get']('default:OMV_NFSD_V4_PSEUDO_ROOT_OPTIONS', 'ro,fsid=0,root_squash,no_subtree_check') -%}
{%- set pseudo_root_options = salt['pillar.get']('default:OMV_NFSD_V4_PSEUDO_ROOT_OPTIONS', 'ro,fsid=0,root_squash,subtree_check') -%}
{%- set pseudo_root_enabled = salt['pillar.get']('default:OMV_NFSD_V4_PSEUDO_ROOT_ENABLED', 'yes') -%}
{%- set shares_distinct_sfref = salt['omv_conf.get_by_filter'](
'conf.service.nfs.share',
Expand Down

0 comments on commit 5d8bf75

Please sign in to comment.