Skip to content

Commit

Permalink
Merge pull request #15 from 0xPranjl/main, fixes #10
Browse files Browse the repository at this point in the history
moved credentials from firebase.js to .env
  • Loading branch information
shadmanhere authored Oct 3, 2022
2 parents b980546 + dc6001d commit 747c605
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 8 deletions.
10 changes: 9 additions & 1 deletion .env.sample
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
REACT_APP_API_KEY=gh_xxxxxxxx...
REACT_APP_API_KEY=gh_xxxxxxxx...,
REACT_APP_FIRBASE_API_KEY='AIzaSyDs-rxvOLmskYhudQWPOxl-whELlKKUYhs',
REACT_APP_AUTHDOMAIN="issue-finder.firebaseapp.com",
REACT_APP_PROJECTID='issue-finder',
REACT_APP_STORAGEBUCKET='issue-finder.appspot.com',
REACT_APP_MSG_SENDERID='918268898722',
REACT_APP_APPID='1:918268898722:web:653b04454a9eee41d896fb',
REACT_APP_MEASUREMENTID='G-C28740E7D5'

14 changes: 7 additions & 7 deletions src/utility/firebase.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ import { getAnalytics } from 'firebase/analytics';
// Your web app's Firebase configuration
// For Firebase JS SDK v7.20.0 and later, measurementId is optional
const firebaseConfig = {
apiKey: 'AIzaSyDs-rxvOLmskYhudQWPOxl-whELlKKUYhs',
authDomain: 'issue-finder.firebaseapp.com',
projectId: 'issue-finder',
storageBucket: 'issue-finder.appspot.com',
messagingSenderId: '918268898722',
appId: '1:918268898722:web:653b04454a9eee41d896fb',
measurementId: 'G-C28740E7D5'
apiKey:process.env.REACT_APP_FIRBASE_API_KEY,
authDomain: process.env.REACT_APP_AUTHDOMAIN,
projectId: process.env.REACT_APP_PROJECTID,
storageBucket:process.env.REACT_APP_STORAGEBUCKET,
messagingSenderId:process.env.REACT_APP_MSG_SENDERID,
appId: process.env.REACT_APP_APPID,
measurementId: process.env.REACT_APP_MEASUREMENTID
};

// Initialize Firebase
Expand Down

0 comments on commit 747c605

Please sign in to comment.