Feat: Implement websocketOptions as arg to CS connection #58
+97
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduhenke
reviewed
Dec 19, 2024
| const url = `${this.csUrl}/${this.id}`; | ||
| const socket = new WebSocket(url, SUPPORTED_PROTOCOLS); | ||
| const socket = new WebSocket(url, SUPPORTED_PROTOCOLS, { | ||
| auth: `${this.id}:${connectArgs?.auth}`, |
There was a problem hiding this comment.
this always sets the auth key, which may not be desirable for other users of this library. I suggest moving this to the layer above, and just pass the connectArgs to the WebSocket constructor, that way it won't break any existing code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
We need to pass CP password at websocket connection to CS.
HOW
Websocket connection has options parameters that allow to pass some configs as auth.