CELO-261 Feat(ts-ocpp): Allows central-system to close chargepoint connections #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2024 15:50
… with an application defined code
AntonioLuizWeingartner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Whenever the central-system closes a concurrent ws connection, the cs-proxy should do the same. In order to signal the cs-proxy to close the corresponding chargepoint connection, we must close the cs-proxy <-> central-system connection with a specific application defined code.
Application specific codes in websockets are in the range of 4000 to 4999: https://github.com/Luka967/websocket-close-codes
HOW
Adds a new parameter to the closeConnection method of the centralSystem
code, which is a number that will be passed to the close method of the WebSocket instanceRELEASE NOTES