feat(objectionary#376): fix all qulice suggestions

src/main/java/org/eolang/opeo/decompilation/DecompilerState.java

@@ -52,7 +52,7 @@ public final class DecompilerState {
      * Current operand stack.
      * It might have some values inside.
      */
-    private final OperandStack stack;
+    private final OperandStack ostack;
 
     /**
      * Method local variables.
@@ -88,7 +88,7 @@ public DecompilerState(
         final LocalVariables vars
     ) {
         this.opcodes = opcodes;
-        this.stack = stack;
+        this.ostack = stack;
         this.vars = vars;
     }
 
@@ -142,6 +142,6 @@ public AstNode variable(final int index, final Type type) {
      * @return Operand stack.
      */
     public OperandStack stack() {
-        return this.stack;
+        return this.ostack;
     }
 }

src/main/java/org/eolang/opeo/decompilation/agents/AddAgent.java

@@ -28,8 +28,8 @@
 import java.util.Set;
 import org.eolang.opeo.ast.Addition;
 import org.eolang.opeo.ast.AstNode;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**
@@ -38,6 +38,9 @@
  */
 public final class AddAgent implements DecompilationAgent {
 
+    /**
+     * Supported opcodes.
+     */
     private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.IADD,

src/main/java/org/eolang/opeo/decompilation/agents/AllAgents.java

@@ -29,14 +29,13 @@
 import org.eolang.opeo.LabelInstruction;
 import org.eolang.opeo.ast.Opcode;
 import org.eolang.opeo.ast.OpcodeName;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**
  * All agents that try to decompile incoming instructions.
  * @since 0.2
- * @checkstyle ClassFanOutComplexityCheck (500 lines)
  * @todo #376:90min Decompilation Finish Condition.
  *  Currently we decompile until we out of instructions.
  *  But this might be incorrect when we start decompile high-level constructs.
@@ -48,6 +47,7 @@
  *  We should refactor it to a more elegant solution.
  *  For example, each agent might provide a list of instructions it can decompile.
  *  By doing this we can infer the entire list of supported and unsupported instructions.
+ * @checkstyle ClassFanOutComplexityCheck (500 lines)
  */
 public final class AllAgents implements DecompilationAgent {
 

src/main/java/org/eolang/opeo/decompilation/agents/BipushAgent.java

@@ -27,8 +27,8 @@
 import java.util.HashSet;
 import java.util.Set;
 import org.eolang.opeo.ast.Literal;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**
@@ -37,6 +37,9 @@
  */
 public final class BipushAgent implements DecompilationAgent {
 
+    /**
+     * Supported opcodes.
+     */
     private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.BIPUSH

src/main/java/org/eolang/opeo/decompilation/agents/ConstAgent.java

@@ -28,17 +28,21 @@
 import java.util.Set;
 import org.eolang.opeo.ast.AstNode;
 import org.eolang.opeo.ast.Literal;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**
  * Iconst instruction handler.
  * @since 0.1
+ * @checkstyle CyclomaticComplexityCheck (500 lines)
  */
 public final class ConstAgent implements DecompilationAgent {
 
-    private final Set<Integer> SUPPORTED = new HashSet<>(
+    /**
+     * Supported opcodes.
+     */
+    private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.ICONST_M1,
             Opcodes.ICONST_0,
@@ -60,7 +64,7 @@ public final class ConstAgent implements DecompilationAgent {
     @Override
     public void handle(final DecompilerState state) {
         final int opcode = state.instruction().opcode();
-        if (this.SUPPORTED.contains(opcode)) {
+        if (ConstAgent.SUPPORTED.contains(opcode)) {
             final AstNode res;
             switch (opcode) {
                 case Opcodes.ICONST_M1:
@@ -89,10 +93,16 @@ public void handle(final DecompilerState state) {
                     res = ConstAgent.doubleConstant(opcode);
                     state.stack().push(res);
                     break;
+                default:
+                    throw new UnsupportedOperationException(
+                        String.format(
+                            "Constant handler for opcode %s is not supported yet",
+                            opcode
+                        )
+                    );
             }
             state.popInstruction();
         }
-
     }
 
     /**

src/main/java/org/eolang/opeo/decompilation/agents/DupAgent.java

@@ -27,8 +27,8 @@
 import java.util.HashSet;
 import java.util.Set;
 import org.eolang.opeo.ast.Duplicate;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.OperandStack;
 import org.objectweb.asm.Opcodes;
 
@@ -38,6 +38,9 @@
  */
 public final class DupAgent implements DecompilationAgent {
 
+    /**
+     * Supported opcodes.
+     */
     private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.DUP

src/main/java/org/eolang/opeo/decompilation/agents/GetFieldAgent.java

@@ -25,8 +25,8 @@
 
 import org.eolang.opeo.ast.Attributes;
 import org.eolang.opeo.ast.FieldRetrieval;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**

src/main/java/org/eolang/opeo/decompilation/agents/GetStaticAgent.java

@@ -24,8 +24,8 @@
 package org.eolang.opeo.decompilation.agents;
 
 import org.eolang.opeo.ast.ClassField;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**

src/main/java/org/eolang/opeo/decompilation/agents/IfAgent.java

@@ -28,8 +28,8 @@
 import java.util.Set;
 import org.eolang.opeo.ast.AstNode;
 import org.eolang.opeo.ast.If;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.OperandStack;
 import org.objectweb.asm.Label;
 import org.objectweb.asm.Opcodes;
@@ -43,6 +43,9 @@
  */
 public final class IfAgent implements DecompilationAgent {
 
+    /**
+     * Supported opcodes.
+     */
     private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.IF_ICMPGT

src/main/java/org/eolang/opeo/decompilation/agents/InvokedynamicAgent.java

@@ -27,8 +27,8 @@
 import java.util.List;
 import org.eolang.opeo.ast.AstNode;
 import org.eolang.opeo.ast.DynamicInvocation;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Handle;
 import org.objectweb.asm.Opcodes;
 import org.objectweb.asm.Type;

src/main/java/org/eolang/opeo/decompilation/agents/InvokespecialAgent.java

@@ -33,8 +33,8 @@
 import org.eolang.opeo.ast.NewAddress;
 import org.eolang.opeo.ast.Super;
 import org.eolang.opeo.ast.This;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 import org.objectweb.asm.Type;
 

src/main/java/org/eolang/opeo/decompilation/agents/InvokestaticAgent.java

@@ -29,8 +29,8 @@
 import org.eolang.opeo.ast.Attributes;
 import org.eolang.opeo.ast.Owner;
 import org.eolang.opeo.ast.StaticInvocation;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 import org.objectweb.asm.Type;
 

src/main/java/org/eolang/opeo/decompilation/agents/InvokevirtualAgent.java

@@ -28,8 +28,8 @@
 import org.eolang.opeo.ast.AstNode;
 import org.eolang.opeo.ast.Attributes;
 import org.eolang.opeo.ast.Invocation;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 import org.objectweb.asm.Type;
 

src/main/java/org/eolang/opeo/decompilation/agents/LabelAgent.java

@@ -27,8 +27,8 @@
 import org.eolang.opeo.ast.AstNode;
 import org.eolang.opeo.ast.Label;
 import org.eolang.opeo.ast.Labeled;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 
 /**
  * Label instruction handler.

src/main/java/org/eolang/opeo/decompilation/agents/LdcAgent.java

@@ -24,8 +24,8 @@
 package org.eolang.opeo.decompilation.agents;
 
 import org.eolang.opeo.ast.Constant;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**

src/main/java/org/eolang/opeo/decompilation/agents/LoadAgent.java

@@ -26,8 +26,8 @@
 import java.util.Arrays;
 import java.util.HashSet;
 import java.util.Set;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 import org.objectweb.asm.Type;
 

src/main/java/org/eolang/opeo/decompilation/agents/MulAgent.java

@@ -38,6 +38,9 @@
  */
 public final class MulAgent implements DecompilationAgent {
 
+    /**
+     * Supported opcodes.
+     */
     private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.IMUL,

src/main/java/org/eolang/opeo/decompilation/agents/NewAgent.java

@@ -27,8 +27,8 @@
 import java.util.HashSet;
 import java.util.Set;
 import org.eolang.opeo.ast.NewAddress;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**
@@ -37,13 +37,15 @@
  */
 public final class NewAgent implements DecompilationAgent {
 
+    /**
+     * Supported opcodes.
+     */
     private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.NEW
         )
     );
 
-
     @Override
     public void handle(final DecompilerState state) {
         if (NewAgent.SUPPORTED.contains(state.instruction().opcode())) {

src/main/java/org/eolang/opeo/decompilation/agents/NewArrayAgent.java

@@ -29,8 +29,8 @@
 import org.eolang.opeo.ast.ArrayConstructor;
 import org.eolang.opeo.ast.AstNode;
 import org.eolang.opeo.ast.Reference;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.OperandStack;
 import org.objectweb.asm.Opcodes;
 
@@ -40,6 +40,9 @@
  */
 public final class NewArrayAgent implements DecompilationAgent {
 
+    /**
+     * Supported opcodes.
+     */
     private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.ANEWARRAY

src/main/java/org/eolang/opeo/decompilation/agents/PutFieldAgent.java

@@ -27,8 +27,8 @@
 import org.eolang.opeo.ast.Attributes;
 import org.eolang.opeo.ast.Field;
 import org.eolang.opeo.ast.FieldAssignment;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.objectweb.asm.Opcodes;
 
 /**

src/main/java/org/eolang/opeo/decompilation/agents/ReturnAgent.java

@@ -27,8 +27,8 @@
 import java.util.HashSet;
 import java.util.Set;
 import org.eolang.opeo.ast.Return;
-import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.DecompilationAgent;
+import org.eolang.opeo.decompilation.DecompilerState;
 import org.eolang.opeo.decompilation.OperandStack;
 import org.objectweb.asm.Opcodes;
 
@@ -39,7 +39,10 @@
  */
 public final class ReturnAgent implements DecompilationAgent {
 
-    private final Set<Integer> SUPPORTED = new HashSet<>(
+    /**
+     * Supported opcodes.
+     */
+    private static final Set<Integer> SUPPORTED = new HashSet<>(
         Arrays.asList(
             Opcodes.RETURN,
             Opcodes.IRETURN,
@@ -53,7 +56,7 @@ public final class ReturnAgent implements DecompilationAgent {
     @Override
     public void handle(final DecompilerState state) {
         final int opcode = state.instruction().opcode();
-        if (this.SUPPORTED.contains(opcode)) {
+        if (ReturnAgent.SUPPORTED.contains(opcode)) {
             final OperandStack stack = state.stack();
             if (opcode == Opcodes.RETURN) {
                 stack.push(new Return());