-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue suspend design doc #3752
base: master
Are you sure you want to change the base?
Queue suspend design doc #3752
Conversation
|
||
队列在Open,Closing,Unknown状态下时,处理Suspend和Resume action。 | ||
|
||
- 当队列为Open,Closing或Unknown状态时,收到Suspend action,将队列更新为suspended状态,收到Resume action时,不做任何处理。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see in checkQueueState()
that only Open
queues can Submit jobs now.
Is it expected that a Queue in the Unknown
state should not accept Job submissions?
If so, should accepting the Suspended
state be considered as inconsistent with the job submission behavior in the Unknown
state, as is the case with Closed
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah checkQueueState()
block pod submission,pod&job can be submitted when queue is open
or suspended
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Monokaix <[email protected]>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add queue suspend/resume capability design doc.