Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuration of ipFamilyPolicy #3741

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

dongjiang1989
Copy link
Contributor

@dongjiang1989 dongjiang1989 commented Sep 20, 2024

support dualstack with helm charts deployment

@volcano-sh-bot
Copy link
Contributor

Welcome @dongjiang1989!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2024
@dongjiang1989
Copy link
Contributor Author

/assign @wpeng102

@Monokaix
Copy link
Member

Please also update installer/README.md.

@dongjiang1989
Copy link
Contributor Author

Please also update installer/README.md.

Thanks. @Monokaix
Done.

@Monokaix
Copy link
Member

Hi please squash to one commit.

commit 45a28ba
Author: dongjiang1989 <[email protected]>
Date:   Tue Sep 24 11:41:05 2024 +0800

    update

    Signed-off-by: dongjiang1989 <[email protected]>

commit 33ecdf8
Author: dongjiang1989 <[email protected]>
Date:   Tue Sep 24 11:37:37 2024 +0800

    update readme

    Signed-off-by: dongjiang1989 <[email protected]>

commit 2d089eb
Author: dongjiang1989 <[email protected]>
Date:   Fri Sep 20 09:41:43 2024 +0800

    allow configuration of ipFamilyPolicy

    Signed-off-by: dongjiang1989 <[email protected]>

Signed-off-by: dongjiang1989 <[email protected]>
@dongjiang1989
Copy link
Contributor Author

Hi please squash to one commit.

Thanks. Git Squash done.

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@volcano-sh-bot volcano-sh-bot merged commit 639a4ba into volcano-sh:master Sep 30, 2024
14 checks passed
@dongjiang1989 dongjiang1989 deleted the dualstack-support branch October 9, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants