Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helm package flag to set version in generate chart release #3648

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Monokaix
Copy link
Member

@Monokaix Monokaix commented Aug 1, 2024

Curently volcano use sed to replace helm chart version, but it's easy to make mistakes and make release charts failed,this pr #2985 changed the version format and leads sed match faliled.

While helm package itself has supports flag to set version, so we should use the official command to release charts and avoid mistakes.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@Monokaix
Copy link
Member Author

Monokaix commented Aug 1, 2024

charts release CI has already failed currently.
image

@Monokaix
Copy link
Member Author

Monokaix commented Aug 1, 2024

cc @wangyang0616 @lowang-bh

@lowang-bh
Copy link
Member

👍
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@wangyang0616
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@volcano-sh-bot volcano-sh-bot merged commit e2cbe0d into volcano-sh:master Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants