Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix job CRD metadata.annotations: Too long error #3197

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix job CRD metadata.annotations: Too long error #3197

merged 1 commit into from
Nov 15, 2023

Conversation

Monokaix
Copy link
Member

Fix #3107

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 13, 2023
@Monokaix Monokaix force-pushed the fix-annotatin-too-long branch 2 times, most recently from 062b142 to c008e50 Compare November 13, 2023 07:18
@Monokaix Monokaix changed the title fix job CRD metadata.annotations: Too long error fix job CRD metadata.annotations: Too long error Nov 13, 2023
hwdef
hwdef reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this repair is good, because when the yaml is regenerated, it will be overwritten.

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2023
@Monokaix
Copy link
Member Author

I don't think this repair is good, because when the yaml is regenerated, it will be overwritten.

yeah, it's a question, kubectl apply --server-side is another way.

@volcano-sh-bot volcano-sh-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2023
@Monokaix
Copy link
Member Author

I don't think this repair is good, because when the yaml is regenerated, it will be overwritten.

Limit the volcano job crd yaml's description when using CONTROLLER_GEN, please check it once more.

hwdef
hwdef reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
william-wang
william-wang reviewed Nov 15, 2023
View reviewed changes
Makefile Show resolved Hide resolved
william-wang
william-wang approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@volcano-sh-bot volcano-sh-bot merged commit 76c088d into volcano-sh:master Nov 15, 2023
13 checks passed
@Monokaix Monokaix deleted the fix-annotatin-too-long branch November 17, 2023 03:34
@Monokaix Monokaix mentioned this pull request Nov 25, 2023
Closed
@Monokaix Monokaix mentioned this pull request Dec 15, 2023
Merged
@lowang-bh lowang-bh mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@william-wang william-wang

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jobs.batch.volcano.sh is invalid: metadata.annotation: Too long
4 participants
@Monokaix @volcano-sh-bot @william-wang @hwdef